fix: invalid duration passed to helm 3 upgrade (#864)

Fixes #863
2019-09-19 08:30:29 +09:00 · 2019-09-19 08:30:29 +09:00 · 2e98e907b0
parent b762ab0b78
commit 2e98e907b0
1 changed files with 5 additions and 1 deletions
--- a/pkg/state/state.go
+++ b/pkg/state/state.go
@ -1343,7 +1343,11 @@ func (st *HelmState) flagsForUpgrade(helm helmexec.Interface, release *ReleaseSp
 		timeout = *release.Timeout
 	}
 	if timeout != 0 {
-		flags = append(flags, "--timeout", fmt.Sprintf("%d", timeout))
+		duration := strconv.Itoa(timeout)
+		if isHelm3() {
+			duration += "s"
+		}
+		flags = append(flags, "--timeout", duration)
 	}

 	if release.Force != nil && *release.Force || release.Force == nil && st.HelmDefaults.Force {