From 2e98e907b0af2c61cd03946547d2e954e3e53df1 Mon Sep 17 00:00:00 2001 From: KUOKA Yusuke Date: Thu, 19 Sep 2019 08:30:29 +0900 Subject: [PATCH] fix: invalid duration passed to helm 3 upgrade (#864) Fixes #863 --- pkg/state/state.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/state/state.go b/pkg/state/state.go index e6afdf4a..bb3128f1 100644 --- a/pkg/state/state.go +++ b/pkg/state/state.go @@ -1343,7 +1343,11 @@ func (st *HelmState) flagsForUpgrade(helm helmexec.Interface, release *ReleaseSp timeout = *release.Timeout } if timeout != 0 { - flags = append(flags, "--timeout", fmt.Sprintf("%d", timeout)) + duration := strconv.Itoa(timeout) + if isHelm3() { + duration += "s" + } + flags = append(flags, "--timeout", duration) } if release.Force != nil && *release.Force || release.Force == nil && st.HelmDefaults.Force {