public_git/bambuddy
1
0
Fork 0
mirror of https://github.com/maziggy/bambuddy.git synced 2026-09-29 18:51:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

chore(installer): add RunOnceId to UninstallRun entries

Browse Source 
Silences Inno Setup's "missing RunOnceId" warning. Both commands
  (stop service, remove firewall rule) are already idempotent, so the
  behavioural effect is nil — this is purely a cleanliness fix to keep
  the build log warning-free.
This commit is contained in:
maziggy
2026-06-10 13:25:05 +02:00
parent 10e190b72b
commit 106ba7938a
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
installers/windows/bambuddy.iss
+5 -3
View File
@@ -110,11 +110,13 @@ Filename: "netsh.exe"; Parameters: "advfirewall firewall add rule name=""Bambudd
Filename: "http://localhost:{#DefaultPort}"; Flags: shellexec postinstall nowait skipifsilent; Description: "Open Bambuddy Dashboard"
[UninstallRun]
; Stop + deregister the service before file removal
Filename: "{app}\service\uninstall-service.bat"; Parameters: """{app}"""; Flags: runhidden waituntilterminated
; Stop + deregister the service before file removal. RunOnceId makes the
; entry run-once per uninstall pass (Inno Setup default is to re-run on
; every pass, which can fire multiple times during upgrade flows).
Filename: "{app}\service\uninstall-service.bat"; Parameters: """{app}"""; Flags: runhidden waituntilterminated; RunOnceId: "StopBambuddyService"
; Remove the firewall rule (silently — if it doesn't exist, netsh just complains)
Filename: "netsh.exe"; Parameters: "advfirewall firewall delete rule name=""Bambuddy Dashboard"""; Flags: runhidden waituntilterminated
Filename: "netsh.exe"; Parameters: "advfirewall firewall delete rule name=""Bambuddy Dashboard"""; Flags: runhidden waituntilterminated; RunOnceId: "RemoveFirewallRule"
[UninstallDelete]
; Remove install dir contents; leave ProgramData\Bambuddy alone so the