From 106ba7938a076e705ef8d63ebfc493c5e29aec5b Mon Sep 17 00:00:00 2001 From: maziggy Date: Wed, 10 Jun 2026 13:25:05 +0200 Subject: [PATCH] chore(installer): add RunOnceId to UninstallRun entries MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Silences Inno Setup's "missing RunOnceId" warning. Both commands (stop service, remove firewall rule) are already idempotent, so the behavioural effect is nil — this is purely a cleanliness fix to keep the build log warning-free. --- installers/windows/bambuddy.iss | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/installers/windows/bambuddy.iss b/installers/windows/bambuddy.iss index 40c763222..e2c325655 100644 --- a/installers/windows/bambuddy.iss +++ b/installers/windows/bambuddy.iss @@ -110,11 +110,13 @@ Filename: "netsh.exe"; Parameters: "advfirewall firewall add rule name=""Bambudd Filename: "http://localhost:{#DefaultPort}"; Flags: shellexec postinstall nowait skipifsilent; Description: "Open Bambuddy Dashboard" [UninstallRun] -; Stop + deregister the service before file removal -Filename: "{app}\service\uninstall-service.bat"; Parameters: """{app}"""; Flags: runhidden waituntilterminated +; Stop + deregister the service before file removal. RunOnceId makes the +; entry run-once per uninstall pass (Inno Setup default is to re-run on +; every pass, which can fire multiple times during upgrade flows). +Filename: "{app}\service\uninstall-service.bat"; Parameters: """{app}"""; Flags: runhidden waituntilterminated; RunOnceId: "StopBambuddyService" ; Remove the firewall rule (silently — if it doesn't exist, netsh just complains) -Filename: "netsh.exe"; Parameters: "advfirewall firewall delete rule name=""Bambuddy Dashboard"""; Flags: runhidden waituntilterminated +Filename: "netsh.exe"; Parameters: "advfirewall firewall delete rule name=""Bambuddy Dashboard"""; Flags: runhidden waituntilterminated; RunOnceId: "RemoveFirewallRule" [UninstallDelete] ; Remove install dir contents; leave ProgramData\Bambuddy alone so the