public_git/actions-runner-controller
1
0
Fork 0
mirror of https://github.com/actions-runner-controller/actions-runner-controller.git synced 2026-09-30 01:21:30 +02:00
Code Issues Projects Releases Wiki Activity

Remove constants orphaned by #4059 and unused proxy env var names (#4675)

Browse Source
This commit is contained in:
Junya Okabe
2026-09-22 15:28:05 +02:00
committed by GitHub
parent ff70227908
commit 390ceb03f6
2 changed files with 4 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
controllers/actions.github.com/constants.go
+1 -11
View File
@@ -17,13 +17,6 @@ const (
EnvVarRunnerDeprecatedExitCode = "ACTIONS_RUNNER_RETURN_VERSION_DEPRECATED_EXIT_CODE"
)
// Environment variable names used to set proxy variables for containers
const (
EnvVarHTTPProxy = "http_proxy"
EnvVarHTTPSProxy = "https_proxy"
EnvVarNoProxy = "no_proxy"
)
// Labels applied to resources
const (
// Kubernetes labels
@@ -105,7 +98,4 @@ const resourceOwnerKey = ".metadata.controller"
const autoscalingRunnerSetOwnerKey = ".spec.autoscalingRunnerSet"
// EphemeralRunner pod creation failure reasons
const (
ReasonTooManyPodFailures = "TooManyPodFailures"
ReasonInvalidPodFailure = "InvalidPod"
)
const ReasonInvalidPodFailure = "InvalidPod"
controllers/actions.github.com/ephemeralrunner_controller_test.go
+3 -3
View File
@@ -1512,7 +1512,7 @@ var _ = Describe("EphemeralRunner", func() {
).Should(Succeed(), "failed to get ephemeral runner pod")
Expect(pod.Spec.Containers[0].Env).To(ContainElement(corev1.EnvVar{
Name: EnvVarHTTPProxy,
Name: "http_proxy",
ValueFrom: &corev1.EnvVarSource{
SecretKeyRef: &corev1.SecretKeySelector{
LocalObjectReference: corev1.LocalObjectReference{
@@ -1524,7 +1524,7 @@ var _ = Describe("EphemeralRunner", func() {
}))
Expect(pod.Spec.Containers[0].Env).To(ContainElement(corev1.EnvVar{
Name: EnvVarHTTPSProxy,
Name: "https_proxy",
ValueFrom: &corev1.EnvVarSource{
SecretKeyRef: &corev1.SecretKeySelector{
LocalObjectReference: corev1.LocalObjectReference{
@@ -1536,7 +1536,7 @@ var _ = Describe("EphemeralRunner", func() {
}))
Expect(pod.Spec.Containers[0].Env).To(ContainElement(corev1.EnvVar{
Name: EnvVarNoProxy,
Name: "no_proxy",
ValueFrom: &corev1.EnvVarSource{
SecretKeyRef: &corev1.SecretKeySelector{
LocalObjectReference: corev1.LocalObjectReference{