diff --git a/controllers/actions.github.com/constants.go b/controllers/actions.github.com/constants.go index a7b249e7..161b7b0c 100644 --- a/controllers/actions.github.com/constants.go +++ b/controllers/actions.github.com/constants.go @@ -17,13 +17,6 @@ const ( EnvVarRunnerDeprecatedExitCode = "ACTIONS_RUNNER_RETURN_VERSION_DEPRECATED_EXIT_CODE" ) -// Environment variable names used to set proxy variables for containers -const ( - EnvVarHTTPProxy = "http_proxy" - EnvVarHTTPSProxy = "https_proxy" - EnvVarNoProxy = "no_proxy" -) - // Labels applied to resources const ( // Kubernetes labels @@ -105,7 +98,4 @@ const resourceOwnerKey = ".metadata.controller" const autoscalingRunnerSetOwnerKey = ".spec.autoscalingRunnerSet" // EphemeralRunner pod creation failure reasons -const ( - ReasonTooManyPodFailures = "TooManyPodFailures" - ReasonInvalidPodFailure = "InvalidPod" -) +const ReasonInvalidPodFailure = "InvalidPod" diff --git a/controllers/actions.github.com/ephemeralrunner_controller_test.go b/controllers/actions.github.com/ephemeralrunner_controller_test.go index cfc5a266..5e254470 100644 --- a/controllers/actions.github.com/ephemeralrunner_controller_test.go +++ b/controllers/actions.github.com/ephemeralrunner_controller_test.go @@ -1512,7 +1512,7 @@ var _ = Describe("EphemeralRunner", func() { ).Should(Succeed(), "failed to get ephemeral runner pod") Expect(pod.Spec.Containers[0].Env).To(ContainElement(corev1.EnvVar{ - Name: EnvVarHTTPProxy, + Name: "http_proxy", ValueFrom: &corev1.EnvVarSource{ SecretKeyRef: &corev1.SecretKeySelector{ LocalObjectReference: corev1.LocalObjectReference{ @@ -1524,7 +1524,7 @@ var _ = Describe("EphemeralRunner", func() { })) Expect(pod.Spec.Containers[0].Env).To(ContainElement(corev1.EnvVar{ - Name: EnvVarHTTPSProxy, + Name: "https_proxy", ValueFrom: &corev1.EnvVarSource{ SecretKeyRef: &corev1.SecretKeySelector{ LocalObjectReference: corev1.LocalObjectReference{ @@ -1536,7 +1536,7 @@ var _ = Describe("EphemeralRunner", func() { })) Expect(pod.Spec.Containers[0].Env).To(ContainElement(corev1.EnvVar{ - Name: EnvVarNoProxy, + Name: "no_proxy", ValueFrom: &corev1.EnvVarSource{ SecretKeyRef: &corev1.SecretKeySelector{ LocalObjectReference: corev1.LocalObjectReference{