mirror of
https://github.com/cirruslabs/tart.git
synced 2026-10-11 08:25:35 +02:00
Compare commits
11
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
d5fcd1b4e7 | ||
|
|
05edeac562 | ||
|
|
917c0b51ed | ||
|
|
e3b4f71f77 | ||
|
|
e92c3b900f | ||
|
|
5c1c6bd315 | ||
|
|
27d3e2c5da | ||
|
|
a80ec74a42 | ||
|
|
8ac52501c3 | ||
|
|
bb4acb2468 | ||
|
|
65aea029ab |
@@ -5,12 +5,15 @@ set -eu
|
||||
ARCH="$1"
|
||||
SCRATCH_PATH=".build/$ARCH"
|
||||
OUTPUT_PATH=".build/prebuilt/$ARCH"
|
||||
SWIFT_COMPATIBILITY_LIBRARY="$(dirname "$(xcrun --find swiftc)")/../lib/swift-6.2/macosx/libswiftCompatibilitySpan.dylib"
|
||||
|
||||
swift build \
|
||||
--build-system swiftbuild \
|
||||
--scratch-path "$SCRATCH_PATH" \
|
||||
--arch "$ARCH" \
|
||||
--configuration release \
|
||||
-Xlinker -weak_library \
|
||||
-Xlinker "$SWIFT_COMPATIBILITY_LIBRARY" \
|
||||
--product tart
|
||||
|
||||
BIN_PATH=$(swift build \
|
||||
|
||||
@@ -34,6 +34,9 @@ struct Clone: AsyncParsableCommand {
|
||||
@Flag(help: "create a stacked disk that uses the source image as an immutable base")
|
||||
var stacked: Bool = false
|
||||
|
||||
@Flag(help: "overwrite an existing local VM")
|
||||
var overwrite: Bool = false
|
||||
|
||||
@Option(help: ArgumentHelp("limit automatic pruning to n gigabytes", valueName: "n"))
|
||||
var pruneLimit: UInt = 100
|
||||
|
||||
@@ -52,6 +55,8 @@ struct Clone: AsyncParsableCommand {
|
||||
let localStorage = try VMStorageLocal()
|
||||
let remoteName = try? RemoteName(sourceName)
|
||||
|
||||
try rejectExistingDestination(localStorage)
|
||||
|
||||
if stacked {
|
||||
guard remoteName != nil else {
|
||||
throw ValidationError("--stacked requires a remote image")
|
||||
@@ -98,6 +103,8 @@ struct Clone: AsyncParsableCommand {
|
||||
let lock = try FileLock(lockURL: Config().tartHomeDir)
|
||||
try lock.lock()
|
||||
|
||||
try rejectExistingDestination(localStorage)
|
||||
|
||||
let sourceState = try sourceVM.state()
|
||||
let generateMAC = try localStorage.hasVMsWithMACAddress(macAddress: sourceVM.macAddress())
|
||||
&& sourceState != .Suspended
|
||||
@@ -151,4 +158,11 @@ struct Clone: AsyncParsableCommand {
|
||||
try? tmpVMDir.removeFromDisk()
|
||||
})
|
||||
}
|
||||
|
||||
private func rejectExistingDestination(_ localStorage: VMStorageLocal) throws {
|
||||
let destinationURL = localStorage.baseURL.appendingPathComponent(newName, isDirectory: true)
|
||||
if !overwrite && FileManager.default.fileExists(atPath: destinationURL.path) {
|
||||
throw ValidationError("VM \"\(newName)\" already exists, use --overwrite to replace it")
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -31,7 +31,8 @@ struct Get: AsyncParsableCommand {
|
||||
OS: vmConfig.os,
|
||||
CPU: vmConfig.cpuCount,
|
||||
Memory: memorySizeInMb,
|
||||
Disk: HumanReadableByteCount(try vmDir.diskSizeBytes()) { $0 / 1000 / 1000 / 1000 },
|
||||
// ASIF capacity lookup can fail while a running VM holds the disk open.
|
||||
Disk: HumanReadableByteCount(try? vmDir.diskSizeBytes()) { $0 / 1000 / 1000 / 1000 },
|
||||
DiskFormat: vmConfig.diskFormat.rawValue,
|
||||
Size: HumanReadableByteCount(try vmDir.allocatedSizeBytes()) {
|
||||
String(format: "%.3f", Float($0) / 1000 / 1000 / 1000)
|
||||
|
||||
@@ -20,7 +20,7 @@ struct IP: AsyncParsableCommand {
|
||||
|
||||
@Option(help: ArgumentHelp("Strategy for resolving IP address",
|
||||
discussion: """
|
||||
By default, Tart is using a "dhcp" resolver which parses the DHCP lease file on host and tries to find an entry containing the VM's MAC address. This method is fast and the most reliable, but only works for VMs are not using the bridged networking.\n
|
||||
By default, Tart is using a "dhcp" resolver which parses the DHCP reservation file, then the lease file on host and tries to find an entry containing the VM's MAC address. This method is fast and the most reliable, but only works for VMs not using the bridged networking.\n
|
||||
Alternatively, Tart has an "arp" resolver which calls an external "arp" executable and parses it's output. This works for VMs using bridged networking and returns their IP, but when they generate enough network activity to populate the host's ARP table. Note that "arp" strategy won't work for VMs using the Softnet networking.\n
|
||||
A third strategy, "agent" works in all cases reliably, but requires Guest agent for Tart VMs (https://github.com/cirruslabs/tart-guest-agent) to be installed inside of a VM.
|
||||
"""))
|
||||
@@ -60,6 +60,9 @@ struct IP: AsyncParsableCommand {
|
||||
return ip
|
||||
}
|
||||
case .dhcp:
|
||||
if let bootptab = try Bootptab(), let ip = try bootptab.ResolveMACAddress(macAddress: vmMACAddress) {
|
||||
return ip
|
||||
}
|
||||
if let leases = try Leases(), let ip = leases.ResolveMACAddress(macAddress: vmMACAddress) {
|
||||
return ip
|
||||
}
|
||||
|
||||
@@ -42,7 +42,8 @@ struct List: AsyncParsableCommand {
|
||||
try VMInfo(
|
||||
Source: "local",
|
||||
Name: name,
|
||||
Disk: HumanReadableByteCount(try vmDir.diskSizeBytes()) { $0 / 1000 / 1000 / 1000 },
|
||||
// ASIF capacity lookup can fail while a running VM holds the disk open.
|
||||
Disk: HumanReadableByteCount(try? vmDir.diskSizeBytes()) { $0 / 1000 / 1000 / 1000 },
|
||||
Size: HumanReadableByteCount(try vmDir.allocatedSizeBytes()) { $0 / 1000 / 1000 / 1000 },
|
||||
Accessed: formatAccessDate(try vmDir.accessDate()),
|
||||
Running: vmDir.running(),
|
||||
@@ -56,7 +57,7 @@ struct List: AsyncParsableCommand {
|
||||
try VMInfo(
|
||||
Source: "OCI",
|
||||
Name: name,
|
||||
Disk: HumanReadableByteCount(try vmDir.diskSizeBytes()) { $0 / 1000 / 1000 / 1000 },
|
||||
Disk: HumanReadableByteCount(try? vmDir.diskSizeBytes()) { $0 / 1000 / 1000 / 1000 },
|
||||
Size: HumanReadableByteCount(try vmDir.allocatedSizeBytes()) { $0 / 1000 / 1000 / 1000 },
|
||||
Accessed: formatAccessDate(try vmDir.accessDate()),
|
||||
Running: vmDir.running(),
|
||||
|
||||
@@ -234,6 +234,9 @@ struct Run: AsyncParsableCommand {
|
||||
""", valueName: "file descriptor"))
|
||||
var netSoftnetControlFd: Int32?
|
||||
|
||||
@Option(help: .hidden)
|
||||
var netSoftnetExtra: [String] = []
|
||||
|
||||
@Option(help: ArgumentHelp("Comma-separated list of TCP ports to expose (e.g. --net-softnet-expose 2222:22,8080:80)", discussion: """
|
||||
Options are comma-separated and are as follows:
|
||||
|
||||
@@ -323,7 +326,7 @@ struct Run: AsyncParsableCommand {
|
||||
}
|
||||
|
||||
// Automatically enable --net-softnet when any of its related options are specified
|
||||
if netSoftnetAllow != nil || netSoftnetBlock != nil || netSoftnetExpose != nil || netSoftnetControlFd != nil {
|
||||
if netSoftnetAllow != nil || netSoftnetBlock != nil || netSoftnetExpose != nil || netSoftnetControlFd != nil || !netSoftnetExtra.isEmpty {
|
||||
netSoftnet = true
|
||||
}
|
||||
|
||||
@@ -428,7 +431,7 @@ struct Run: AsyncParsableCommand {
|
||||
try vmDir.regenerateMACAddress()
|
||||
}
|
||||
|
||||
if (netSoftnet || netHost) && isInteractiveSession() {
|
||||
if netSoftnet && isInteractiveSession() {
|
||||
try Softnet.configureSUIDBitIfNeeded()
|
||||
}
|
||||
|
||||
@@ -696,6 +699,8 @@ struct Run: AsyncParsableCommand {
|
||||
softnetExtraArguments += ["--expose", netSoftnetExpose]
|
||||
}
|
||||
|
||||
softnetExtraArguments += netSoftnetExtra
|
||||
|
||||
if netSoftnet {
|
||||
let config = try VMConfig.init(fromURL: vmDir.configURL)
|
||||
|
||||
@@ -703,9 +708,11 @@ struct Run: AsyncParsableCommand {
|
||||
}
|
||||
|
||||
if netHost {
|
||||
let config = try VMConfig.init(fromURL: vmDir.configURL)
|
||||
guard #available(macOS 26, *) else {
|
||||
throw ValidationError("--net-host requires macOS 26 (Tahoe) or newer")
|
||||
}
|
||||
|
||||
return try Softnet(vmMACAddress: config.macAddress.string, extraArguments: ["--vm-net-type", "host"] + softnetExtraArguments, controlFD: netSoftnetControlFd)
|
||||
return try NetworkHost()
|
||||
}
|
||||
|
||||
if netBridged.count > 0 {
|
||||
|
||||
@@ -37,6 +37,12 @@ class ControlSocket {
|
||||
|
||||
do {
|
||||
self.serverChannel = try await ServerBootstrap(group: eventLoopGroup)
|
||||
.serverChannelInitializer { channel in
|
||||
channel.pipeline.addHandler(
|
||||
ControlSocketAcceptErrorHandler(),
|
||||
name: "ControlSocketAcceptErrorHandler"
|
||||
)
|
||||
}
|
||||
.bind(unixDomainSocketPath: controlSocketURL.relativePath) { childChannel in
|
||||
childChannel.eventLoop.makeCompletedFuture {
|
||||
return try NIOAsyncChannel<ByteBuffer, ByteBuffer>(
|
||||
@@ -125,3 +131,16 @@ class ControlSocket {
|
||||
return fd
|
||||
}
|
||||
}
|
||||
|
||||
private final class ControlSocketAcceptErrorHandler: ChannelInboundHandler {
|
||||
typealias InboundIn = Channel
|
||||
typealias InboundOut = Channel
|
||||
|
||||
func errorCaught(context: ChannelHandlerContext, error: Error) {
|
||||
if error is NIOFcntlFailedError {
|
||||
context.channel.read()
|
||||
} else {
|
||||
context.fireErrorCaught(error)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,15 +1,19 @@
|
||||
import Foundation
|
||||
|
||||
struct HumanReadableByteCount: Encodable, CustomStringConvertible {
|
||||
private let byteCount: Int
|
||||
private let byteCount: Int?
|
||||
private let jsonValue: any Encodable
|
||||
|
||||
init<JSONValue: Encodable>(_ byteCount: Int, encodedAs: (Int) -> JSONValue) {
|
||||
init<JSONValue: Encodable>(_ byteCount: Int?, encodedAs: (Int) -> JSONValue) {
|
||||
self.byteCount = byteCount
|
||||
self.jsonValue = encodedAs(byteCount)
|
||||
self.jsonValue = byteCount.map(encodedAs)
|
||||
}
|
||||
|
||||
var description: String {
|
||||
guard let byteCount else {
|
||||
return "-"
|
||||
}
|
||||
|
||||
let formatter = MeasurementFormatter()
|
||||
formatter.unitOptions = .naturalScale
|
||||
formatter.unitStyle = .medium
|
||||
|
||||
@@ -0,0 +1,70 @@
|
||||
import Foundation
|
||||
import Network
|
||||
|
||||
struct Bootptab {
|
||||
private var reservations: [MACAddress: Swift.Set<IPv4Address>] = [:]
|
||||
|
||||
init?(_ fromURL: URL = URL(fileURLWithPath: "/etc/bootptab")) throws {
|
||||
let contents: String
|
||||
|
||||
do {
|
||||
contents = try String(contentsOf: fromURL, encoding: .utf8)
|
||||
} catch {
|
||||
if error.isFileNotFound() {
|
||||
return nil
|
||||
}
|
||||
|
||||
throw error
|
||||
}
|
||||
|
||||
for line in contents.split(whereSeparator: \.isNewline) {
|
||||
// Skip comment lines
|
||||
guard !line.hasPrefix("#") else {
|
||||
continue
|
||||
}
|
||||
|
||||
let fields = line.split(whereSeparator: \.isWhitespace)
|
||||
|
||||
// Skip lines that don't look like reservation fields
|
||||
guard fields.count >= 4 else {
|
||||
continue
|
||||
}
|
||||
|
||||
// Assign reservation fields
|
||||
let hardwareType = fields[1]
|
||||
let hardwareAddress = fields[2]
|
||||
let ipAddress = fields[3]
|
||||
|
||||
// Skip non-Ethernet reservations
|
||||
guard hardwareType == "1" else {
|
||||
continue
|
||||
}
|
||||
|
||||
// Skip malformed MAC addresses
|
||||
guard let mac = MACAddress(fromString: String(hardwareAddress)) else {
|
||||
continue
|
||||
}
|
||||
|
||||
// Skip malformed IPv4 addresses
|
||||
guard let ip = IPv4Address(String(ipAddress)) else {
|
||||
continue
|
||||
}
|
||||
|
||||
reservations[mac, default: []].insert(ip)
|
||||
}
|
||||
}
|
||||
|
||||
func ResolveMACAddress(macAddress: MACAddress) throws -> IPv4Address? {
|
||||
guard let addresses = reservations[macAddress] else {
|
||||
return nil
|
||||
}
|
||||
|
||||
if addresses.count > 1 {
|
||||
let addresses = addresses.map { $0.debugDescription }.sorted().joined(separator: ", ")
|
||||
|
||||
throw RuntimeError.Generic("multiple DHCP reservations in /etc/bootptab for \(macAddress): \(addresses)")
|
||||
}
|
||||
|
||||
return addresses.first
|
||||
}
|
||||
}
|
||||
@@ -11,7 +11,11 @@ struct MACAddress: Equatable, Hashable, CustomStringConvertible {
|
||||
}
|
||||
|
||||
for (index, component) in components.enumerated() {
|
||||
mac[index] = UInt8(component, radix: 16)!
|
||||
guard let byte = UInt8(component, radix: 16) else {
|
||||
return nil
|
||||
}
|
||||
|
||||
mac[index] = byte
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -0,0 +1,61 @@
|
||||
import Foundation
|
||||
import Semaphore
|
||||
import Virtualization
|
||||
import vmnet
|
||||
|
||||
@available(macOS 26, *)
|
||||
class NetworkHost: Network {
|
||||
private let attachment: VZNetworkDeviceAttachment
|
||||
|
||||
init() throws {
|
||||
var status = vmnet_return_t.VMNET_SUCCESS
|
||||
guard let configuration = vmnet_network_configuration_create(.VMNET_HOST_MODE, &status) else {
|
||||
throw RuntimeError.Generic("Failed to create a vmnet configuration for host-only networking: \(status)")
|
||||
}
|
||||
defer { Unmanaged<CFTypeRef>.fromOpaque(UnsafeRawPointer(configuration)).release() }
|
||||
|
||||
guard let network = vmnet_network_create(configuration, &status) else {
|
||||
var message = "Failed to create a vmnet network for host-only networking: \(status)"
|
||||
|
||||
if status == .VMNET_NOT_AUTHORIZED {
|
||||
message += ". Creating a vmnet network requires root privileges or a properly signed app with the com.apple.vm.networking entitlement."
|
||||
}
|
||||
|
||||
throw RuntimeError.Generic(message)
|
||||
}
|
||||
defer { Unmanaged<CFTypeRef>.fromOpaque(UnsafeRawPointer(network)).release() }
|
||||
|
||||
attachment = VZVmnetNetworkDeviceAttachment(network: network)
|
||||
}
|
||||
|
||||
func attachments() -> [VZNetworkDeviceAttachment] {
|
||||
[attachment]
|
||||
}
|
||||
|
||||
func run(_ sema: AsyncSemaphore) throws {
|
||||
// no-op, only used for Softnet
|
||||
}
|
||||
|
||||
func stop() async throws {
|
||||
// no-op, only used for Softnet
|
||||
}
|
||||
}
|
||||
|
||||
extension vmnet_return_t: @retroactive CustomStringConvertible {
|
||||
public var description: String {
|
||||
switch self {
|
||||
case .VMNET_SUCCESS: return "successfully completed"
|
||||
case .VMNET_FAILURE: return "general failure"
|
||||
case .VMNET_MEM_FAILURE: return "memory allocation failure"
|
||||
case .VMNET_INVALID_ARGUMENT: return "invalid argument specified"
|
||||
case .VMNET_SETUP_INCOMPLETE: return "interface setup is not complete"
|
||||
case .VMNET_INVALID_ACCESS: return "permission denied"
|
||||
case .VMNET_PACKET_TOO_BIG: return "packet size larger than MTU"
|
||||
case .VMNET_BUFFER_EXHAUSTED: return "buffers exhausted in kernel"
|
||||
case .VMNET_TOO_MANY_PACKETS: return "packet count exceeds limit"
|
||||
case .VMNET_SHARING_SERVICE_BUSY: return "vmnet interface cannot be started as conflicting sharing service is in use"
|
||||
case .VMNET_NOT_AUTHORIZED: return "the operation could not be completed due to missing authorization"
|
||||
@unknown default: return "unknown vmnet status (\(rawValue))"
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -111,27 +111,24 @@ struct TokenResponse: Decodable, Authentication {
|
||||
}
|
||||
|
||||
class Registry {
|
||||
private let baseURL: URL
|
||||
let baseURL: URL
|
||||
let namespace: String
|
||||
let credentialsProviders: [CredentialsProvider]
|
||||
let authenticationKeeper = AuthenticationKeeper()
|
||||
|
||||
var host: String? {
|
||||
guard let host = baseURL.host else { return nil }
|
||||
|
||||
if let port = baseURL.port {
|
||||
return "\(host):\(port)"
|
||||
}
|
||||
|
||||
return host
|
||||
}
|
||||
// Host with an optional port (e.g. "127.0.0.1:5000"), which is used for naming
|
||||
// and credentials lookup. For Docker Hub it stays "docker.io", while baseURL
|
||||
// points to registry-1.docker.io.
|
||||
let host: String?
|
||||
|
||||
init(baseURL: URL,
|
||||
namespace: String,
|
||||
host: String? = nil,
|
||||
credentialsProviders: [CredentialsProvider] = [EnvironmentCredentialsProvider(), DockerConfigCredentialsProvider(), KeychainCredentialsProvider()]
|
||||
) throws {
|
||||
self.baseURL = baseURL
|
||||
self.namespace = namespace
|
||||
self.host = host ?? Registry.hostWithPort(of: baseURL)
|
||||
self.credentialsProviders = credentialsProviders
|
||||
}
|
||||
|
||||
@@ -142,9 +139,9 @@ class Registry {
|
||||
credentialsProviders: [CredentialsProvider] = [EnvironmentCredentialsProvider(), DockerConfigCredentialsProvider(), KeychainCredentialsProvider()]
|
||||
) throws {
|
||||
let proto = insecure ? "http" : "https"
|
||||
let baseURLComponents = URLComponents(string: proto + "://" + host + "/v2/")!
|
||||
var baseURLComponents = URLComponents(string: proto + "://" + host + "/v2/")!
|
||||
|
||||
guard let baseURL = baseURLComponents.url else {
|
||||
guard var baseURL = baseURLComponents.url else {
|
||||
var hint = ""
|
||||
|
||||
if host.hasPrefix("http://") || host.hasPrefix("https://") {
|
||||
@@ -154,7 +151,33 @@ class Registry {
|
||||
throw RuntimeError.ImproperlyFormattedHost(host, hint)
|
||||
}
|
||||
|
||||
try self.init(baseURL: baseURL, namespace: namespace, credentialsProviders: credentialsProviders)
|
||||
// Naming and credentials lookup use the host and port of the original URL,
|
||||
// so it's "docker.io" for Docker Hub and "127.0.0.1:5000" for "127.0.0.1:05000"
|
||||
let normalizedHost = Registry.hostWithPort(of: baseURL)
|
||||
|
||||
// Docker Hub serves its registry API from registry-1.docker.io, while docker.io,
|
||||
// the host used in image names, redirects to Docker's website. URLSession follows
|
||||
// these redirects, so we'd get an HTML page with HTTP 200 instead of an API
|
||||
// response, which breaks pushing, pulling and "tart login" credentials validation.
|
||||
//
|
||||
// Host names are case insensitive, and only the host is replaced,
|
||||
// so an explicit port like in "Docker.IO:443" is kept.
|
||||
if baseURLComponents.host?.lowercased() == "docker.io" {
|
||||
baseURLComponents.host = "registry-1.docker.io"
|
||||
baseURL = baseURLComponents.url!
|
||||
}
|
||||
|
||||
try self.init(baseURL: baseURL, namespace: namespace, host: normalizedHost, credentialsProviders: credentialsProviders)
|
||||
}
|
||||
|
||||
private static func hostWithPort(of url: URL) -> String? {
|
||||
guard let host = url.host else { return nil }
|
||||
|
||||
if let port = url.port {
|
||||
return "\(host):\(port)"
|
||||
}
|
||||
|
||||
return host
|
||||
}
|
||||
|
||||
func ping() async throws {
|
||||
@@ -421,12 +444,8 @@ class Registry {
|
||||
await authenticationKeeper.set(try TokenResponse.parse(fromData: data))
|
||||
}
|
||||
|
||||
private func lookupCredentials() throws -> (String, String)? {
|
||||
var host = baseURL.host!
|
||||
|
||||
if let port = baseURL.port {
|
||||
host += ":\(port)"
|
||||
}
|
||||
func lookupCredentials() throws -> (String, String)? {
|
||||
let host = self.host!
|
||||
|
||||
for provider in credentialsProviders {
|
||||
do {
|
||||
|
||||
@@ -8,21 +8,21 @@ extension URL {
|
||||
}
|
||||
|
||||
func updateAccessDate(_ accessDate: Date = Date()) throws {
|
||||
let attrs = try resourceValues(forKeys: [.contentAccessDateKey])
|
||||
let modificationDate = attrs.contentAccessDate!
|
||||
|
||||
let times = [accessDate.asTimeval(), modificationDate.asTimeval()]
|
||||
let ret = utimes(path, times)
|
||||
let times = [accessDate.asTimespec(), timespec(tv_sec: 0, tv_nsec: Int(UTIME_OMIT))]
|
||||
let ret = utimensat(AT_FDCWD, path, times, 0)
|
||||
if ret != 0 {
|
||||
let details = Errno(rawValue: CInt(errno))
|
||||
|
||||
throw RuntimeError.FailedToUpdateAccessDate("utimes(2) failed: \(details)")
|
||||
throw RuntimeError.FailedToUpdateAccessDate("utimensat(2) failed: \(details)")
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
extension Date {
|
||||
func asTimeval() -> timeval {
|
||||
timeval(tv_sec: Int(timeIntervalSince1970), tv_usec: 0)
|
||||
func asTimespec() -> timespec {
|
||||
let seconds = floor(timeIntervalSince1970)
|
||||
let nanoseconds = (timeIntervalSince1970 - seconds) * 1_000_000_000
|
||||
|
||||
return timespec(tv_sec: Int(seconds), tv_nsec: Int(nanoseconds))
|
||||
}
|
||||
}
|
||||
|
||||
@@ -469,10 +469,6 @@ struct VMDirectory: Prunable {
|
||||
}
|
||||
}
|
||||
|
||||
func diskSizeGB() throws -> Int {
|
||||
try diskSizeBytes() / 1000 / 1000 / 1000
|
||||
}
|
||||
|
||||
func markExplicitlyPulled() {
|
||||
FileManager.default.createFile(atPath: explicitlyPulledMark.path, contents: nil)
|
||||
}
|
||||
|
||||
@@ -38,7 +38,8 @@ class VMStorageHelper {
|
||||
|
||||
extension NSError {
|
||||
func isFileNotFound() -> Bool {
|
||||
return self.code == NSFileNoSuchFileError || self.code == NSFileReadNoSuchFileError
|
||||
return self.domain == NSCocoaErrorDomain &&
|
||||
(self.code == NSFileNoSuchFileError || self.code == NSFileReadNoSuchFileError)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -0,0 +1,71 @@
|
||||
import XCTest
|
||||
import Network
|
||||
@testable import tart
|
||||
|
||||
final class BootptabTests: XCTestCase {
|
||||
func testCommentedReservation() throws {
|
||||
let url = FileManager.default.temporaryDirectory.appendingPathComponent(UUID().uuidString)
|
||||
let contents = """
|
||||
%
|
||||
#client1 1 02:ab:00:01:02:03 192.168.64.2
|
||||
"""
|
||||
try contents.write(to: url, atomically: true, encoding: .utf8)
|
||||
defer { try? FileManager.default.removeItem(at: url) }
|
||||
|
||||
let bootptab = try XCTUnwrap(Bootptab(url))
|
||||
|
||||
XCTAssertNil(try bootptab.ResolveMACAddress(
|
||||
macAddress: MACAddress(fromString: "02:ab:00:01:02:03")!))
|
||||
}
|
||||
|
||||
func testCommentedReservationWithActiveReservation() throws {
|
||||
let url = FileManager.default.temporaryDirectory.appendingPathComponent(UUID().uuidString)
|
||||
let contents = """
|
||||
%
|
||||
#client1 1 02:ab:00:01:02:03 192.168.64.2
|
||||
client1 1 02:ab:00:01:02:03 192.168.64.3
|
||||
"""
|
||||
try contents.write(to: url, atomically: true, encoding: .utf8)
|
||||
defer { try? FileManager.default.removeItem(at: url) }
|
||||
|
||||
let bootptab = try XCTUnwrap(Bootptab(url))
|
||||
|
||||
XCTAssertEqual(try bootptab.ResolveMACAddress(
|
||||
macAddress: MACAddress(fromString: "02:ab:00:01:02:03")!), IPv4Address("192.168.64.3"))
|
||||
}
|
||||
|
||||
func testResolveMACAddress() throws {
|
||||
let url = FileManager.default.temporaryDirectory.appendingPathComponent(UUID().uuidString)
|
||||
|
||||
// A missing file produces no Bootptab
|
||||
XCTAssertNil(try Bootptab(url))
|
||||
|
||||
// Write reservations with duplicates, conflicts, and a malformed MAC address
|
||||
let contents = """
|
||||
# DHCP reservations
|
||||
%
|
||||
client1 1 02:ab:00:01:02:03 192.168.64.2
|
||||
client2 1 02:ab:00:01:02:03 192.168.64.2
|
||||
client3 1 02:ab:00:01:02:04 192.168.64.3
|
||||
client4 1 02:ab:00:01:02:04 192.168.65.3
|
||||
malformed 1 02:gg:00:01:02:03 192.168.64.9
|
||||
"""
|
||||
try contents.write(to: url, atomically: true, encoding: .utf8)
|
||||
defer { try? FileManager.default.removeItem(at: url) }
|
||||
|
||||
// Parse the reservation file
|
||||
let bootptab = try XCTUnwrap(Bootptab(url))
|
||||
|
||||
// Identical reservations resolve to one address
|
||||
XCTAssertEqual(try bootptab.ResolveMACAddress(
|
||||
macAddress: MACAddress(fromString: "02:ab:00:01:02:03")!), IPv4Address("192.168.64.2"))
|
||||
|
||||
// An unknown MAC address has no reservation
|
||||
XCTAssertNil(try bootptab.ResolveMACAddress(
|
||||
macAddress: MACAddress(fromString: "02:ab:00:01:02:05")!))
|
||||
|
||||
// Conflicting reservations produce an error
|
||||
XCTAssertThrowsError(try bootptab.ResolveMACAddress(
|
||||
macAddress: MACAddress(fromString: "02:ab:00:01:02:04")!))
|
||||
}
|
||||
}
|
||||
@@ -4,6 +4,85 @@ import XCTest
|
||||
@testable import tart
|
||||
|
||||
final class CommandBehaviorTests: XCTestCase {
|
||||
func testListSurvivesUnavailableDiskCapacity() async throws {
|
||||
try await withTemporaryTartHome {
|
||||
let previousPath = try installUnavailableDiskutil()
|
||||
defer { restoreEnvironment("PATH", to: previousPath) }
|
||||
|
||||
let local = try VMStorageLocal()
|
||||
let oci = try VMStorageOCI()
|
||||
for (name, diskFormat) in [("unavailable", DiskImageFormat.asif), ("healthy", .raw)] {
|
||||
let remoteName = try RemoteName("example.com/org/\(name):latest")
|
||||
for vmDir in [try local.create(name), try oci.create(remoteName)] {
|
||||
var vmConfig = config()
|
||||
vmConfig.diskFormat = diskFormat
|
||||
try vmConfig.save(toURL: vmDir.configURL)
|
||||
XCTAssertTrue(FileManager.default.createFile(atPath: vmDir.nvramURL.path, contents: Data()))
|
||||
// The diskutil stub simulates a locked ASIF disk without needing a running VM.
|
||||
XCTAssertTrue(FileManager.default.createFile(
|
||||
atPath: vmDir.diskURL.path,
|
||||
contents: Data(repeating: 0, count: 4096)
|
||||
))
|
||||
if diskFormat == .asif {
|
||||
XCTAssertThrowsError(try vmDir.diskSizeBytes())
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
for sourceArguments in [[], ["--source", "local"], ["--source", "oci"]] {
|
||||
let json = try await commandOutput(List.self, sourceArguments + ["--format", "json"])
|
||||
let rows = try XCTUnwrap(JSONSerialization.jsonObject(with: Data(json.utf8)) as? [[String: Any]])
|
||||
XCTAssertEqual(rows.count, sourceArguments.isEmpty ? 4 : 2)
|
||||
for row in rows {
|
||||
let name = try XCTUnwrap(row["Name"] as? String)
|
||||
if name.contains("unavailable") {
|
||||
XCTAssertTrue(row["Disk"] is NSNull)
|
||||
} else {
|
||||
XCTAssertEqual(row["Disk"] as? Int, 0)
|
||||
}
|
||||
XCTAssertEqual(row["State"] as? String, "stopped")
|
||||
XCTAssertEqual(row["Running"] as? Bool, false)
|
||||
}
|
||||
|
||||
let text = try await commandOutput(List.self, sourceArguments)
|
||||
XCTAssertTrue(text.contains("unavailable"))
|
||||
XCTAssertTrue(text.contains("healthy"))
|
||||
XCTAssertTrue(text.contains("-"))
|
||||
|
||||
let quiet = try await commandOutput(List.self, sourceArguments + ["--quiet"])
|
||||
XCTAssertEqual(quiet.split(separator: "\n").map(String.init), rows.compactMap { $0["Name"] as? String })
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func testGetSurvivesUnavailableDiskCapacity() async throws {
|
||||
try await withTemporaryTartHome {
|
||||
let previousPath = try installUnavailableDiskutil()
|
||||
defer { restoreEnvironment("PATH", to: previousPath) }
|
||||
|
||||
let vmDir = try VMStorageLocal().create("unavailable")
|
||||
var vmConfig = config()
|
||||
vmConfig.diskFormat = .asif
|
||||
try vmConfig.save(toURL: vmDir.configURL)
|
||||
XCTAssertTrue(FileManager.default.createFile(atPath: vmDir.nvramURL.path, contents: Data()))
|
||||
XCTAssertTrue(FileManager.default.createFile(
|
||||
atPath: vmDir.diskURL.path,
|
||||
contents: Data(repeating: 0, count: 4096)
|
||||
))
|
||||
XCTAssertThrowsError(try vmDir.diskSizeBytes())
|
||||
|
||||
let json = try await commandOutput(Get.self, ["unavailable", "--format", "json"])
|
||||
let info = try XCTUnwrap(JSONSerialization.jsonObject(with: Data(json.utf8)) as? [String: Any])
|
||||
XCTAssertTrue(info["Disk"] is NSNull)
|
||||
XCTAssertEqual(info["DiskFormat"] as? String, "asif")
|
||||
XCTAssertEqual(info["State"] as? String, "stopped")
|
||||
|
||||
let text = try await commandOutput(Get.self, ["unavailable"])
|
||||
XCTAssertTrue(text.contains("asif"))
|
||||
XCTAssertTrue(text.contains("-"))
|
||||
}
|
||||
}
|
||||
|
||||
func testNoUSBAccessoriesDoesNotEnableSuspendable() throws {
|
||||
try withTemporaryTartHome {
|
||||
let vmDir = try VMStorageLocal().create("no-usb-accessories")
|
||||
@@ -37,6 +116,66 @@ final class CommandBehaviorTests: XCTestCase {
|
||||
}
|
||||
}
|
||||
|
||||
func testFileNotFoundRequiresCocoaErrorDomain() {
|
||||
XCTAssertTrue(NSError(domain: NSCocoaErrorDomain, code: NSFileNoSuchFileError).isFileNotFound())
|
||||
XCTAssertTrue(NSError(domain: NSCocoaErrorDomain, code: NSFileReadNoSuchFileError).isFileNotFound())
|
||||
XCTAssertFalse(RuntimeError.VMIsRunning("running").isFileNotFound())
|
||||
}
|
||||
|
||||
func testCloneRejectsExistingDestinationUnlessOverwriteIsRequested() async throws {
|
||||
try await withTemporaryTartHome {
|
||||
let source = try makeStandaloneVM(named: "source", diskContents: "source")
|
||||
let destination = try makeStandaloneVM(named: "destination", diskContents: "existing")
|
||||
|
||||
let command = try Clone.parseAsRoot(["source", "destination"]) as! Clone
|
||||
|
||||
do {
|
||||
try await command.run()
|
||||
XCTFail("expected cloning over an existing VM to be rejected")
|
||||
} catch let error as ValidationError {
|
||||
XCTAssertEqual(error.message, "VM \"destination\" already exists, use --overwrite to replace it")
|
||||
}
|
||||
|
||||
XCTAssertEqual(try Data(contentsOf: destination.diskURL), Data("existing".utf8))
|
||||
XCTAssertTrue(FileManager.default.fileExists(atPath: source.diskURL.path))
|
||||
|
||||
let overwriteCommand = try Clone.parseAsRoot(["--overwrite", "source", "destination"]) as! Clone
|
||||
try await overwriteCommand.run()
|
||||
|
||||
XCTAssertEqual(try Data(contentsOf: destination.diskURL), Data("source".utf8))
|
||||
}
|
||||
}
|
||||
|
||||
func testClonePreservesIncompleteDestination() async throws {
|
||||
try await withTemporaryTartHome {
|
||||
_ = try makeStandaloneVM(named: "source", diskContents: "source")
|
||||
let storage = try VMStorageLocal()
|
||||
let destination = storage.baseURL.appendingPathComponent("destination", isDirectory: true)
|
||||
try FileManager.default.createDirectory(at: destination, withIntermediateDirectories: true)
|
||||
let diskURL = destination.appendingPathComponent("disk.img")
|
||||
try Data("existing".utf8).write(to: diskURL)
|
||||
XCTAssertFalse(storage.exists("destination"))
|
||||
|
||||
// Check both a local source and rejection before any remote registry access.
|
||||
for source in ["source", "invalid.invalid/image:latest"] {
|
||||
let command = try Clone.parseAsRoot([source, "destination"]) as! Clone
|
||||
do {
|
||||
try await command.run()
|
||||
XCTFail("expected an incomplete destination to be preserved")
|
||||
} catch let error as ValidationError {
|
||||
XCTAssertEqual(error.message, "VM \"destination\" already exists, use --overwrite to replace it")
|
||||
}
|
||||
XCTAssertEqual(try Data(contentsOf: diskURL), Data("existing".utf8))
|
||||
XCTAssertFalse(storage.exists("destination"))
|
||||
}
|
||||
|
||||
let command = try Clone.parseAsRoot(["--overwrite", "source", "destination"]) as! Clone
|
||||
try await command.run()
|
||||
XCTAssertEqual(try Data(contentsOf: diskURL), Data("source".utf8))
|
||||
XCTAssertTrue(storage.exists("destination"))
|
||||
}
|
||||
}
|
||||
|
||||
func testSetDiskRejectsStackedVMBeforeSavingConfig() async throws {
|
||||
try await withTemporaryTartHome {
|
||||
let vmDir = try VMStorageLocal().create("stacked")
|
||||
@@ -123,6 +262,14 @@ final class CommandBehaviorTests: XCTestCase {
|
||||
)
|
||||
}
|
||||
|
||||
private func makeStandaloneVM(named name: String, diskContents: String) throws -> VMDirectory {
|
||||
let vmDir = try VMStorageLocal().create(name)
|
||||
try config().save(toURL: vmDir.configURL)
|
||||
XCTAssertTrue(FileManager.default.createFile(atPath: vmDir.nvramURL.path, contents: Data()))
|
||||
XCTAssertTrue(FileManager.default.createFile(atPath: vmDir.diskURL.path, contents: Data(diskContents.utf8)))
|
||||
return vmDir
|
||||
}
|
||||
|
||||
private func temporaryEntries() throws -> [URL] {
|
||||
try FileManager.default.contentsOfDirectory(
|
||||
at: Config().tartTmpDir,
|
||||
@@ -130,6 +277,44 @@ final class CommandBehaviorTests: XCTestCase {
|
||||
)
|
||||
}
|
||||
|
||||
private func installUnavailableDiskutil() throws -> String? {
|
||||
let binDirectory = try temporaryDirectory()
|
||||
let diskutilURL = binDirectory.appendingPathComponent("diskutil")
|
||||
let script = """
|
||||
#!/bin/sh
|
||||
echo 'Resource temporarily unavailable' >&2
|
||||
exit 1
|
||||
"""
|
||||
try script.write(to: diskutilURL, atomically: true, encoding: .utf8)
|
||||
try FileManager.default.setAttributes([.posixPermissions: 0o755], ofItemAtPath: diskutilURL.path)
|
||||
let previousPath = ProcessInfo.processInfo.environment["PATH"]
|
||||
setenv("PATH", binDirectory.path, 1)
|
||||
return previousPath
|
||||
}
|
||||
|
||||
private func commandOutput<Command: AsyncParsableCommand>(
|
||||
_ commandType: Command.Type,
|
||||
_ arguments: [String]
|
||||
) async throws -> String {
|
||||
let outputURL = try temporaryDirectory().appendingPathComponent("stdout")
|
||||
XCTAssertTrue(FileManager.default.createFile(atPath: outputURL.path, contents: nil))
|
||||
let output = try FileHandle(forWritingTo: outputURL)
|
||||
defer { try? output.close() }
|
||||
|
||||
fflush(stdout)
|
||||
let savedStdout = dup(STDOUT_FILENO)
|
||||
defer {
|
||||
fflush(stdout)
|
||||
dup2(savedStdout, STDOUT_FILENO)
|
||||
close(savedStdout)
|
||||
}
|
||||
dup2(output.fileDescriptor, STDOUT_FILENO)
|
||||
var command = try Command.parseAsRoot(arguments) as! Command
|
||||
try await command.run()
|
||||
fflush(stdout)
|
||||
return try String(contentsOf: outputURL, encoding: .utf8)
|
||||
}
|
||||
|
||||
private func withTemporaryTartHome(_ body: () throws -> Void) throws {
|
||||
let home = try temporaryDirectory()
|
||||
let previousHome = ProcessInfo.processInfo.environment["TART_HOME"]
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
import NIO
|
||||
import XCTest
|
||||
@testable import NIOPosix
|
||||
@testable import tart
|
||||
|
||||
// Avoid NSObject.bind and Tart's Darwin type shadowing the system function.
|
||||
@@ -30,6 +31,88 @@ final class ControlSocketTests: XCTestCase {
|
||||
try await eventLoopGroup.shutdownGracefully()
|
||||
}
|
||||
|
||||
func testAcceptErrorsRetryReadingAndForwardOtherErrors() async throws {
|
||||
let temporaryDirectory = try makeTemporaryDirectory()
|
||||
let originalDirectory = FileManager.default.currentDirectoryPath
|
||||
defer {
|
||||
FileManager.default.changeCurrentDirectoryPath(originalDirectory)
|
||||
try? FileManager.default.removeItem(at: temporaryDirectory)
|
||||
}
|
||||
|
||||
let socketURL = URL(fileURLWithPath: "control.sock", relativeTo: temporaryDirectory)
|
||||
let controlSocket = try await ControlSocket(socketURL)
|
||||
let channel = controlSocket.serverChannel.channel
|
||||
let observations = try await channel.eventLoop.submit {
|
||||
let observer = AcceptErrorObserver()
|
||||
// Placing this after the recovery handler also detects context.read(), which
|
||||
// bypasses downstream backpressure handlers instead of starting at the tail.
|
||||
try channel.pipeline.syncOperations.addHandler(observer)
|
||||
for _ in 0..<3 {
|
||||
channel.pipeline.fireErrorCaught(NIOFcntlFailedError())
|
||||
}
|
||||
let retries = observer.readCount
|
||||
let transientErrors = observer.errors.count
|
||||
channel.pipeline.fireErrorCaught(ChannelError.inputClosed)
|
||||
return (retries, transientErrors, observer.readCount,
|
||||
observer.errors.count, observer.errors.first as? ChannelError)
|
||||
}.get()
|
||||
|
||||
try await controlSocket.serverChannel.executeThenClose { _ in }
|
||||
try await controlSocket.eventLoopGroup.shutdownGracefully()
|
||||
|
||||
XCTAssertEqual(observations.0, 3)
|
||||
XCTAssertEqual(observations.1, 0)
|
||||
XCTAssertEqual(observations.2, 3)
|
||||
XCTAssertEqual(observations.3, 1)
|
||||
XCTAssertEqual(observations.4, .inputClosed)
|
||||
}
|
||||
|
||||
func testAcceptErrorsDoNotEndInboundConnections() async throws {
|
||||
let temporaryDirectory = try makeTemporaryDirectory()
|
||||
let originalDirectory = FileManager.default.currentDirectoryPath
|
||||
defer {
|
||||
FileManager.default.changeCurrentDirectoryPath(originalDirectory)
|
||||
try? FileManager.default.removeItem(at: temporaryDirectory)
|
||||
}
|
||||
|
||||
let socketURL = URL(fileURLWithPath: "control.sock", relativeTo: temporaryDirectory)
|
||||
let controlSocket = try await ControlSocket(socketURL)
|
||||
let serverChannel = controlSocket.serverChannel
|
||||
|
||||
do {
|
||||
try await serverChannel.executeThenClose { inbound in
|
||||
// Bound the wait if the listener stays open but stops accepting connections.
|
||||
let timeout = serverChannel.channel.eventLoop.scheduleTask(in: .seconds(10)) {
|
||||
serverChannel.channel.close(promise: nil)
|
||||
}
|
||||
defer { timeout.cancel() }
|
||||
|
||||
var iterator = inbound.makeAsyncIterator()
|
||||
for _ in 0..<3 {
|
||||
try await serverChannel.channel.eventLoop.submit {
|
||||
serverChannel.channel.pipeline.fireErrorCaught(NIOFcntlFailedError())
|
||||
}.get()
|
||||
|
||||
let clientChannel = try await ClientBootstrap(group: controlSocket.eventLoopGroup)
|
||||
.connectTimeout(.seconds(5))
|
||||
.connect(unixDomainSocketPath: socketURL.path)
|
||||
.get()
|
||||
defer { clientChannel.close(promise: nil) }
|
||||
|
||||
// ControlSocket.run() consumes this stream. A recoverable accept error
|
||||
// must not prevent it from receiving the next connection.
|
||||
let nextChannel = try await iterator.next()
|
||||
let acceptedChannel = try XCTUnwrap(nextChannel, "The listener stopped delivering connections after an accept error")
|
||||
try await acceptedChannel.executeThenClose { _, _ in }
|
||||
}
|
||||
}
|
||||
} catch {
|
||||
try? await controlSocket.eventLoopGroup.shutdownGracefully()
|
||||
throw error
|
||||
}
|
||||
try await controlSocket.eventLoopGroup.shutdownGracefully()
|
||||
}
|
||||
|
||||
func testInitializerPropagatesControlSocketCreationFailure() async throws {
|
||||
let temporaryDirectory = try makeTemporaryDirectory()
|
||||
let originalDirectory = FileManager.default.currentDirectoryPath
|
||||
@@ -94,3 +177,20 @@ final class ControlSocketTests: XCTestCase {
|
||||
return directory
|
||||
}
|
||||
}
|
||||
|
||||
private final class AcceptErrorObserver: ChannelDuplexHandler {
|
||||
typealias InboundIn = Channel
|
||||
typealias OutboundIn = ByteBuffer
|
||||
|
||||
var readCount = 0
|
||||
var errors: [Error] = []
|
||||
|
||||
func read(context: ChannelHandlerContext) {
|
||||
readCount += 1
|
||||
context.read()
|
||||
}
|
||||
|
||||
func errorCaught(context: ChannelHandlerContext, error: Error) {
|
||||
errors.append(error)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -3,6 +3,13 @@ import XCTest
|
||||
@testable import tart
|
||||
|
||||
final class HumanReadableByteCountTests: XCTestCase {
|
||||
func testUnknownByteCount() throws {
|
||||
let unknown = HumanReadableByteCount(nil) { $0 / 1000 / 1000 / 1000 }
|
||||
|
||||
XCTAssertEqual(unknown.description, "-")
|
||||
XCTAssertEqual(String(data: try JSONEncoder().encode(unknown), encoding: .utf8), "null")
|
||||
}
|
||||
|
||||
func testTextAndJSONRepresentations() throws {
|
||||
let integer = HumanReadableByteCount(51_400_000_000) { _ in 51 }
|
||||
let string = HumanReadableByteCount(17_234_000_000) { _ in "17.234" }
|
||||
|
||||
@@ -0,0 +1,88 @@
|
||||
import XCTest
|
||||
@testable import tart
|
||||
|
||||
final class RegistryHostTests: XCTestCase {
|
||||
func testDockerHub() throws {
|
||||
let credentialsProvider = RecordingCredentialsProvider()
|
||||
let registry = try Registry(host: "docker.io", namespace: "org/repo",
|
||||
credentialsProviders: [credentialsProvider])
|
||||
|
||||
// docker.io redirects to Docker's website, so the API
|
||||
// requests should go to registry-1.docker.io instead
|
||||
XCTAssertEqual(registry.baseURL, URL(string: "https://registry-1.docker.io/v2/"))
|
||||
|
||||
// ...while naming and credentials lookup should still use the host specified by the user
|
||||
XCTAssertEqual(registry.host, "docker.io")
|
||||
XCTAssertNil(try registry.lookupCredentials())
|
||||
XCTAssertEqual(credentialsProvider.requestedHosts, ["docker.io"])
|
||||
}
|
||||
|
||||
func testDockerHubIsMatchedCaseInsensitively() throws {
|
||||
let credentialsProvider = RecordingCredentialsProvider()
|
||||
let registry = try Registry(host: "Docker.IO", namespace: "org/repo",
|
||||
credentialsProviders: [credentialsProvider])
|
||||
|
||||
XCTAssertEqual(registry.baseURL, URL(string: "https://registry-1.docker.io/v2/"))
|
||||
XCTAssertEqual(registry.host, "Docker.IO")
|
||||
XCTAssertNil(try registry.lookupCredentials())
|
||||
XCTAssertEqual(credentialsProvider.requestedHosts, ["Docker.IO"])
|
||||
}
|
||||
|
||||
func testDockerHubWithExplicitPort() throws {
|
||||
for host in ["docker.io:443", "DOCKER.IO:443"] {
|
||||
let registry = try Registry(host: host, namespace: "org/repo")
|
||||
|
||||
XCTAssertEqual(registry.baseURL, URL(string: "https://registry-1.docker.io:443/v2/"))
|
||||
XCTAssertEqual(registry.host, host)
|
||||
}
|
||||
}
|
||||
|
||||
func testOtherHostsAreUnchanged() throws {
|
||||
for host in ["ghcr.io", "index.docker.io", "registry-1.docker.io", "registry.hub.docker.com", "127.0.0.1:8080"] {
|
||||
let registry = try Registry(host: host, namespace: "org/repo")
|
||||
|
||||
XCTAssertEqual(registry.baseURL, URL(string: "https://\(host)/v2/"))
|
||||
XCTAssertEqual(registry.host, host)
|
||||
}
|
||||
|
||||
let registry = try Registry(host: "127.0.0.1:5000", namespace: "org/repo", insecure: true)
|
||||
XCTAssertEqual(registry.baseURL, URL(string: "http://127.0.0.1:5000/v2/"))
|
||||
XCTAssertEqual(registry.host, "127.0.0.1:5000")
|
||||
}
|
||||
|
||||
func testHostPortIsNormalized() throws {
|
||||
// Credentials stored for "127.0.0.1:5000" should still be found
|
||||
// when the port is written with a leading zero
|
||||
let credentialsProvider = RecordingCredentialsProvider(credentials: ["127.0.0.1:5000": ("user", "password")])
|
||||
let registry = try Registry(host: "127.0.0.1:05000", namespace: "org/repo", insecure: true,
|
||||
credentialsProviders: [credentialsProvider])
|
||||
|
||||
XCTAssertEqual(registry.baseURL, URL(string: "http://127.0.0.1:05000/v2/"))
|
||||
XCTAssertEqual(registry.host, "127.0.0.1:5000")
|
||||
|
||||
let (user, password) = try XCTUnwrap(registry.lookupCredentials())
|
||||
XCTAssertEqual(user, "user")
|
||||
XCTAssertEqual(password, "password")
|
||||
XCTAssertEqual(credentialsProvider.requestedHosts, ["127.0.0.1:5000"])
|
||||
}
|
||||
}
|
||||
|
||||
fileprivate class RecordingCredentialsProvider: CredentialsProvider {
|
||||
let userFriendlyName = "recording credentials provider"
|
||||
|
||||
let credentials: [String: (String, String)]
|
||||
var requestedHosts: [String] = []
|
||||
|
||||
init(credentials: [String: (String, String)] = [:]) {
|
||||
self.credentials = credentials
|
||||
}
|
||||
|
||||
func retrieve(host: String) throws -> (String, String)? {
|
||||
requestedHosts.append(host)
|
||||
|
||||
return credentials[host]
|
||||
}
|
||||
|
||||
func store(host: String, user: String, password: String) throws {
|
||||
}
|
||||
}
|
||||
@@ -161,6 +161,25 @@ final class SoftnetControlFDTests: XCTestCase {
|
||||
)
|
||||
}
|
||||
|
||||
func testSoftnetExtraArguments() throws {
|
||||
// Prepare a temporary VM for command validation
|
||||
let temporaryHome = try createTemporaryTartHome()
|
||||
let previousHome = ProcessInfo.processInfo.environment["TART_HOME"]
|
||||
setenv("TART_HOME", temporaryHome.path, 1)
|
||||
defer {
|
||||
restoreEnvironment("TART_HOME", value: previousHome)
|
||||
try? FileManager.default.removeItem(at: temporaryHome)
|
||||
}
|
||||
|
||||
// Parse repeated options with a value containing spaces
|
||||
let extra = ["--vm-ip=172.20.0.2", "--vmnet-network=opaque value with spaces"]
|
||||
let command = try Run.parse(["vm"] + extra.map { "--net-softnet-extra=\($0)" })
|
||||
|
||||
// Verify Softnet is enabled and the arguments are preserved
|
||||
XCTAssertTrue(command.netSoftnet)
|
||||
XCTAssertEqual(command.netSoftnetExtra, extra)
|
||||
}
|
||||
|
||||
private func createTemporaryTartHome() throws -> URL {
|
||||
let temporaryHome = URL(fileURLWithPath: NSTemporaryDirectory()).appendingPathComponent(UUID().uuidString)
|
||||
let vm = temporaryHome.appendingPathComponent("vms/vm")
|
||||
|
||||
@@ -2,21 +2,29 @@ import XCTest
|
||||
@testable import tart
|
||||
|
||||
final class URLAccessDateTests: XCTestCase {
|
||||
func testGetAndSetAccessTime() throws {
|
||||
func testUpdateAccessDatePreservesModificationDate() throws {
|
||||
// Create a temporary file
|
||||
let tmpDir = URL(fileURLWithPath: NSTemporaryDirectory(), isDirectory: true)
|
||||
var tmpFile = tmpDir.appendingPathComponent(UUID().uuidString)
|
||||
FileManager.default.createFile(atPath: tmpFile.path, contents: nil)
|
||||
defer { try? FileManager.default.removeItem(at: tmpFile) }
|
||||
|
||||
// Ensure it's access date is different than our desired access date
|
||||
let arbitraryDate = Date.init(year: 2008, month: 09, day: 28, hour: 23, minute: 15)
|
||||
XCTAssertNotEqual(arbitraryDate, try tmpFile.accessDate())
|
||||
// Ensure its access date is different from our desired access date
|
||||
let accessDate = Date.init(year: 2008, month: 09, day: 28, hour: 23, minute: 15)
|
||||
let modificationDate = Date(timeIntervalSince1970: 1_577_836_800.125)
|
||||
try FileManager.default.setAttributes([.modificationDate: modificationDate], ofItemAtPath: tmpFile.path)
|
||||
XCTAssertNotEqual(accessDate, try tmpFile.accessDate())
|
||||
|
||||
// Set our desired access date for a file
|
||||
try tmpFile.updateAccessDate(arbitraryDate)
|
||||
try tmpFile.updateAccessDate(accessDate)
|
||||
|
||||
// Ensure the access date has changed to our value
|
||||
tmpFile.removeCachedResourceValue(forKey: .contentAccessDateKey)
|
||||
XCTAssertEqual(arbitraryDate, try tmpFile.accessDate())
|
||||
XCTAssertEqual(accessDate, try tmpFile.accessDate())
|
||||
|
||||
// Ensure the modification date has not changed
|
||||
tmpFile.removeCachedResourceValue(forKey: .contentModificationDateKey)
|
||||
let attrs = try tmpFile.resourceValues(forKeys: [.contentModificationDateKey])
|
||||
XCTAssertEqual(modificationDate, try XCTUnwrap(attrs.contentModificationDate))
|
||||
}
|
||||
}
|
||||
|
||||
+1
-1
@@ -132,7 +132,7 @@ And no worries, this file will be re-created on the next `tart run`.
|
||||
|
||||
Due to the limitations of the macOS built-in DHCP server, `tart ip` is unable to correctly report the IP addresses for VMs using DHCP client identifiers that are not based on VMs link-layer addresses (MAC addresses).
|
||||
|
||||
By default, when [no `--resolver=arp` is specified](#resolving-the-vms-ip-when-using-bridged-networking), `tart ip` reads the `/var/db/dhcpd_leases` file and tries to find the freshest entry that matches the VM's MAC address (based on the `hw_address` field).
|
||||
By default, when [no `--resolver=arp` is specified](#resolving-the-vms-ip-when-using-bridged-networking), `tart ip` first checks the `/etc/bootptab` file for a matching DHCP reservation. Otherwise, it reads the `/var/db/dhcpd_leases` file and tries to find the freshest entry that matches the VM's MAC address (based on the `hw_address` field).
|
||||
|
||||
However, things starts to break when the VM uses a [DUID-EN](https://metebalci.com/blog/a-note-on-dhcpv6-duid-and-prefix-delegation#duid-types) identifier, for example. One of the notorious examples of this being Ubuntu, using this type of identifier by default on latest versions. This results in the `/var/db/dhcpd_leases` entry for Ubuntu appearing as follows:
|
||||
|
||||
|
||||
@@ -46,7 +46,7 @@ func TestClonePreservesRunningDestination(t *testing.T) {
|
||||
t.Fatal(err)
|
||||
}
|
||||
for range 2 {
|
||||
_, stderr, err := tart.Tart(t, "clone", "source", "destination")
|
||||
_, stderr, err := tart.Tart(t, "clone", "--overwrite", "source", "destination")
|
||||
if err == nil || !strings.Contains(strings.ToLower(stderr), "running") {
|
||||
t.Fatalf("clone must reject the running destination: %v: %s", err, stderr)
|
||||
}
|
||||
@@ -64,7 +64,7 @@ func TestClonePreservesRunningDestination(t *testing.T) {
|
||||
if err := syscall.FcntlFlock(held.Fd(), syscall.F_SETLK, &lock); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, stderr, err := tart.Tart(t, "clone", "source", "destination"); err != nil {
|
||||
if _, stderr, err := tart.Tart(t, "clone", "--overwrite", "source", "destination"); err != nil {
|
||||
t.Fatalf("clone after shutdown: %v: %s", err, stderr)
|
||||
}
|
||||
currentInfo, err := os.Stat(config)
|
||||
|
||||
Reference in New Issue
Block a user