Changed order of sidecar env vars (#980)
* Changed order of sidecar env vars * Cleaned up test code
This commit is contained in:
parent
3a49b485e5
commit
0fa61a6ab3
|
|
@ -531,7 +531,7 @@ func patchSidecarContainers(in []v1.Container, volumeMounts []v1.VolumeMount, su
|
|||
},
|
||||
},
|
||||
}
|
||||
mergedEnv := append(container.Env, env...)
|
||||
mergedEnv := append(env, container.Env...)
|
||||
container.Env = deduplicateEnvVars(mergedEnv, container.Name, logger)
|
||||
result = append(result, container)
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1394,7 +1394,7 @@ func TestSidecars(t *testing.T) {
|
|||
|
||||
// replaced sidecar
|
||||
// the order in env is important
|
||||
scalyrEnv := append([]v1.EnvVar{v1.EnvVar{Name: "SCALYR_API_KEY", Value: "abc"}, v1.EnvVar{Name: "SCALYR_SERVER_HOST", Value: ""}}, env...)
|
||||
scalyrEnv := append(env, v1.EnvVar{Name: "SCALYR_API_KEY", Value: "abc"}, v1.EnvVar{Name: "SCALYR_SERVER_HOST", Value: ""})
|
||||
assert.Contains(t, s.Spec.Template.Spec.Containers, v1.Container{
|
||||
Name: "scalyr-sidecar",
|
||||
Image: "scalyr-image",
|
||||
|
|
|
|||
Loading…
Reference in New Issue