Commit Graph
1637 Commits
Author SHA1 Message Date
Joel Speed 67501f004f Implement refresh relying on obtaining lock 2021-12-06 14:05:58 +00:00
Joel Speed 327211cec9 Refreshing with an invalid session should work
I would like this test to pass, but it currently doesn't. With the 
current implementation, there is a race, if the session is locked, but 
releases before the "handleObtainLockError" starts, then you'll get an 
error, which is not desirable
2021-12-03 23:44:18 +00:00
Joel Speed 1478fefe92 Remove lock release via peek
This doesn't seem right, its not what I'd expect from the session store 
implemented locks.

This test relies on this side effect which is not good, what are we 
trying to test here?
2021-12-03 23:42:42 +00:00
Kevin Kreitner b734de16e6 Refactor refreshSession method to reduce number of return 2021-12-03 23:07:40 +00:00
Kevin Kreitner 2781ea1c95 Try to wait for lock, when obtaining lock failed 2021-12-03 23:07:40 +00:00
Kevin Kreitner 360c753d6f Remove unnecessary err variable definition 2021-12-03 23:07:39 +00:00
Kevin Kreitner 0cb8d23222 Simplify for loop for waiting for lock 2021-12-03 23:07:38 +00:00
Kevin Kreitner f596cbe6cc Update CHANGELOG.md 2021-12-03 23:07:17 +00:00
Kevin Kreitner d9e0933e54 Move validateSession back into refreshSessionIfNeeded 2021-12-03 23:06:46 +00:00
Kevin Kreitner ad8ce2f6a4 Add concurrent requests tests 2021-12-03 23:06:45 +00:00
Kevin Kreitner c5ea345daf Add tests, which consider session lock 2021-12-03 23:06:44 +00:00
Kevin Kreitner fca2d76f33 Fix tests for stored_session.go in middleware 2021-12-03 23:06:43 +00:00
Kevin Kreitner d8663a19a9 Remove unnecessary log output 2021-12-03 23:06:42 +00:00
Kevin Kreitner a8de9862cd Update logger message 2021-12-03 23:06:41 +00:00
Kevin Kreitner 88ab07930e Update update session from store 2021-12-03 23:06:41 +00:00
Kevin Kreitner ccd7a91b2b Add more specific error when updating from store 2021-12-03 23:06:40 +00:00
Kevin Kreitner c6d8cd1ea4 Remove one return statement in getValidatedSession 2021-12-03 23:06:39 +00:00
Kevin Kreitner 86ba2f41ce Refactor StoredSessionHandler 2021-12-03 23:06:38 +00:00
Kevin Kreitner 518e619289 Move session locking to refreshSessionIfNeeded method 2021-12-03 23:06:37 +00:00
Kevin Kreitner 76e3cb3e9a Use const for delay and expire time 2021-12-03 23:06:36 +00:00
Kevin Kreitner 0f545e14d4 Lock session state when refreshing 2021-12-03 23:06:35 +00:00
Kevin Kreitner 58b9f0633a Remove sensitive logging changes 2021-12-03 23:06:34 +00:00
Kevin Kreitner a4ad6bccfb Fix default value flag for sensitive logging 2021-12-03 23:06:33 +00:00
Kevin Kreitner 6b50a55668 Add sensible logging flag to default setup for logger 2021-12-03 23:06:30 +00:00
Joel Speed 1b335a056d Merge pull request #1447 from oauth2-proxy/docker-fixes
Fix docker build/push issues found during last release
2021-11-24 17:31:20 +00:00
Joel Speed ceb015ee22 Update changelog for docker fixes 2021-11-24 17:20:25 +00:00
Joel Speed 8dea8134eb Drop old makefiles in favour of buildx 2021-11-24 17:20:23 +00:00
Joel Speed 60b6dd850a Fix docker build and push for all platforms 2021-11-24 17:20:22 +00:00
Jeeva Kandasamy 6e54ac2745 Update LinkedIn provider validate URL (#1444)
* update LinkedIn validate URL

Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com>

* update changelog

Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com>

* update failed unit test

Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com>
2021-11-19 21:36:33 +00:00
Jack HenschelandJoel Speed 0693856bc3 Explicitly state precedence of config sources in docs (#1439)
I was recently looking into the order in which oauth2-proxy evaluates it configuration options from the various sources.
I think this will also be helpful for other users.
Since oauth2-proxy is using viper, the order of configuration sources is as follows [1]:
> Viper uses the following precedence order. Each item takes precedence over the item below it:
>
>    explicit call to Set
>    flag
>    env
>    config
>    key/value store
>    default

[1] https://github.com/spf13/viper/blob/master/README.md#why-viper

Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk>
2021-11-15 09:24:04 +00:00
Jeeva Kandasamy 7ed4e3c830 Fix docker container multi arch build issue by passing GOARCH details to make build (#1445)
* pass GOARCH details to make process

Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com>

* update changelog

Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com>
2021-11-12 21:42:46 +00:00
Stephan AßmusandJoel Speed 2c668a52d4 Let authentication fail when session validation fails (fixes #1396) (#1433)
* Error page for session validation failure

* Fix existing tests

* Add test-case for session validation failure

* Simplify test

* Add changelog entry for PR

Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk>
2021-11-12 18:36:29 +00:00
Joel Speed 9caf8c7040 Merge pull request #1419 from jangaraj/patch-1
Keycloak OIDC config improvement
2021-11-12 18:25:04 +00:00
Jan Garaj 1e761bf8fd Keycloak OIDC config improvement 2021-10-25 10:01:35 +01:00
Joel Speed 6c379f74db Merge pull request #1412 from oauth2-proxy/release-7.2.0
Release 7.2.0
v7.2.0
2021-10-22 18:19:35 +01:00
Joel Speed 4ee3f13c46 Create versioned docs for release v7.2.x
Created with: yarn run docusaurus docs:version 7.2.x
2021-10-22 18:11:28 +01:00
Joel Speed 976dc35805 Update CHANGELOG for v7.2.0 release 2021-10-22 18:11:26 +01:00
Joel Speed d82c268696 Merge pull request #1403 from openstandia/fix-redis-tls
Improve TLS handling for Redis to support non-standalone mode with TLS
2021-10-19 13:30:53 +01:00
Hiroyuki Wada 7eb3a4fbd5 Improve TLS handling for Redis to support non-standalone mode with TLS 2021-10-19 20:04:49 +09:00
Maciej Strzelecki b49e62f9b2 Initalize TLS.Config when connecting to Redis with TLS (#1296)
* init TLS.Config when connecting to Redis with TLS

* don't overwrite TLS config if it exists

* add tests for Redis with TLS

* remove hardcoded certs

* add GenerateCert func

* use GenerateCert util func

* fix issue reported by go fmt

* limit return statements in GenerateCert
2021-10-19 09:17:42 +01:00
Adam StephensandJoel Speed ea261ca014 fix arg typo in traefik example (#1410)
Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk>
2021-10-18 19:01:40 +01:00
Joel Speed 543a71efad Merge pull request #1411 from oauth2-proxy/fix-exclude-logging-doc
Fix exclude-logging-path documentation
2021-10-18 18:42:18 +01:00
Joel Speed bdab6feb0c Fix exclude-logging-path documentation 2021-10-18 18:36:56 +01:00
Joel Speed 85c02821bf Merge pull request #1391 from oauth2-proxy/docker-buildx-selection
Improve build times by sharing cache and allowing platform selection
2021-10-18 18:36:19 +01:00
Joel Speed 2ce93b6b31 Improve build times by sharing cache and allowing platform selection 2021-10-18 18:19:40 +01:00
Joel Speed 9d8093f470 Merge pull request #1404 from oauth2-proxy/improve-no-auth-error
Improve error message when no cookie is found
2021-10-18 18:16:40 +01:00
Joel Speed d8deaa124b Improve error message when no cookie is found 2021-10-13 19:08:11 +01:00
Joel Speed 6cc7da8993 Merge pull request #1375 from bancek/feature-force-json-errors
Add --force-json-errors flag
2021-10-13 17:09:08 +01:00
Luka Zakrajšek d3e036d619 Add force-json-errors flag 2021-10-05 11:24:47 +02:00
David Emanuel Buchmann fd5e23e1c5 linkedidn: Update provider to v2 (#1315)
* linkedin: Update provider to v2

* changelog: Add change
2021-10-04 15:58:25 +01:00