chore(deps): update dependency golangci/golangci-lint to v2.7.2 (#3254)

* chore(deps): update dependency golangci/golangci-lint to v2.7.2

* chore(linter): fix gocritic deprecation message issue

Signed-off-by: Jan Larwig <jan@larwig.com>

* chore(lint): fix var-naming: avoid package names that conflict with Go standard library package names (revive)

Signed-off-by: Jan Larwig <jan@larwig.com>

---------

Signed-off-by: Jan Larwig <jan@larwig.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jan Larwig <jan@larwig.com>

.github/workflows/ci.yml

@@ -25,7 +25,7 @@ jobs:
     - name: Get dependencies
       env:
         # renovate: datasource=github-tags depName=golangci/golangci-lint
-        GOLANGCI_LINT_VERSION: v2.5.0
+        GOLANGCI_LINT_VERSION: v2.7.2
       run: |
         curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin ${GOLANGCI_LINT_VERSION}
         curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter

.github/workflows/publish-release.yml

@@ -50,7 +50,7 @@ jobs:
     - name: Get dependencies
       env:
         # renovate: datasource=github-tags depName=golangci/golangci-lint
-        GOLANGCI_LINT_VERSION: v2.5.0
+        GOLANGCI_LINT_VERSION: v2.7.2
       run: |
         curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin ${GOLANGCI_LINT_VERSION}
         curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter

oauthproxy.go

@@ -28,7 +28,7 @@ import (
 	"github.com/oauth2-proxy/oauth2-proxy/v7/pkg/authentication/basic"
 	"github.com/oauth2-proxy/oauth2-proxy/v7/pkg/cookies"
 	"github.com/oauth2-proxy/oauth2-proxy/v7/pkg/encryption"
-	proxyhttp "github.com/oauth2-proxy/oauth2-proxy/v7/pkg/http"
+	"github.com/oauth2-proxy/oauth2-proxy/v7/pkg/proxyhttp"
 	"github.com/oauth2-proxy/oauth2-proxy/v7/pkg/util"
 	"github.com/oauth2-proxy/oauth2-proxy/v7/pkg/version"
 

pkg/proxyhttp/http_suite_test.go

@@ -1,4 +1,4 @@
-package http
+package proxyhttp
 
 import (
 	"bytes"

pkg/proxyhttp/server.go

@@ -1,4 +1,4 @@
-package http
+package proxyhttp
 
 import (
 	"context"

pkg/proxyhttp/server_group.go

@@ -1,4 +1,4 @@
-package http
+package proxyhttp
 
 import (
 	"context"

pkg/proxyhttp/server_group_test.go

@@ -1,4 +1,4 @@
-package http
+package proxyhttp
 
 import (
 	"context"

pkg/proxyhttp/server_test.go

@@ -1,4 +1,4 @@
-package http
+package proxyhttp
 
 import (
 	"context"

pkg/proxyhttp/systemd_socket.go

@@ -1,7 +1,7 @@
 //go:build !windows
 // +build !windows
 
-package http
+package proxyhttp
 
 import (
 	"errors"

pkg/proxyhttp/systemd_unsupported.go

@@ -1,7 +1,7 @@
 //go:build windows
 // +build windows
 
-package http
+package proxyhttp
 
 import (
 	"fmt"

providers/provider_default.go

@@ -107,6 +107,7 @@ func (p *ProviderData) Redeem(ctx context.Context, redirectURL, code, codeVerifi
 }
 
 // GetEmailAddress returns the Account email address
+//
 // Deprecated: Migrate to EnrichSession
 func (p *ProviderData) GetEmailAddress(_ context.Context, _ *sessions.SessionState) (string, error) {
 	return "", ErrNotImplemented