public_git
/
kubernetes-operator
mirror of https://github.com/jenkinsci/kubernetes-operator.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Improve tests & docs

This commit is contained in:
Jakub Al-Khalili 2019-07-15 09:56:47 +02:00
parent 811e816b2f
commit 0fed26b733
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/getting-started.md
View File

@ -5,7 +5,7 @@ This document describes a getting started guide for **jenkins-operator** and an
1. [First Steps](#first-steps) 1. [First Steps](#first-steps)
2. [Deploy Jenkins](#deploy-jenkins) 2. [Deploy Jenkins](#deploy-jenkins)
3. [Configure Seed Jobs and Pipelines](#configure-seed-jobs-and-pipelines) 3. [Configure Seed Jobs and Pipelines](#configure-seed-jobs-and-pipelines)
4. [Pulling Docker images from private repositories](#Pulling Docker images from private repositories) 4. [Pulling Docker images from private repositories](#pulling-docker-images-from-private-repositories)
5. [Install Plugins](#install-plugins) 5. [Install Plugins](#install-plugins)
6. [Configure Backup & Restore](#configure-backup-and-restore) 6. [Configure Backup & Restore](#configure-backup-and-restore)
7. [AKS](#aks) 7. [AKS](#aks)

8
pkg/controller/jenkins/configuration/base/validate.go
View File

@ -82,19 +82,19 @@ func (r *ReconcileJenkinsBaseConfiguration) validateImagePullSecret(name string)
} }
if secret.Data["docker-server"] == nil { if secret.Data["docker-server"] == nil {
r.logger.V(log.VWarn).Info("Docker Server is empty") r.logger.V(log.VWarn).Info(fmt.Sprintf("Secret '%s' defined in spec.master.imagePullSecrets doesn't have 'docker-server' key.", name))
return false, nil return false, nil
} }
if secret.Data["docker-username"] == nil { if secret.Data["docker-username"] == nil {
r.logger.V(log.VWarn).Info("Docker Username is empty") r.logger.V(log.VWarn).Info(fmt.Sprintf("Secret '%s' defined in spec.master.imagePullSecrets doesn't have 'docker-username' key.", name))
return false, nil return false, nil
} }
if secret.Data["docker-password"] == nil { if secret.Data["docker-password"] == nil {
r.logger.V(log.VWarn).Info("Docker Password is empty") r.logger.V(log.VWarn).Info(fmt.Sprintf("Secret '%s' defined in spec.master.imagePullSecrets doesn't have 'docker-password' key.", name))
return false, nil return false, nil
} }
if secret.Data["docker-email"] == nil { if secret.Data["docker-email"] == nil {
r.logger.V(log.VWarn).Info("Docker Email is empty") r.logger.V(log.VWarn).Info(fmt.Sprintf("Secret '%s' defined in spec.master.imagePullSecrets doesn't have 'docker-email' key.", name))
return false, nil return false, nil
} }