From 0fed26b7330d7f271e8489e2b380467f71ea14a1 Mon Sep 17 00:00:00 2001 From: Jakub Al-Khalili Date: Mon, 15 Jul 2019 09:56:47 +0200 Subject: [PATCH] Improve tests & docs --- docs/getting-started.md | 2 +- pkg/controller/jenkins/configuration/base/validate.go | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/getting-started.md b/docs/getting-started.md index 7860a4e7..6907e1b3 100644 --- a/docs/getting-started.md +++ b/docs/getting-started.md @@ -5,7 +5,7 @@ This document describes a getting started guide for **jenkins-operator** and an 1. [First Steps](#first-steps) 2. [Deploy Jenkins](#deploy-jenkins) 3. [Configure Seed Jobs and Pipelines](#configure-seed-jobs-and-pipelines) -4. [Pulling Docker images from private repositories](#Pulling Docker images from private repositories) +4. [Pulling Docker images from private repositories](#pulling-docker-images-from-private-repositories) 5. [Install Plugins](#install-plugins) 6. [Configure Backup & Restore](#configure-backup-and-restore) 7. [AKS](#aks) diff --git a/pkg/controller/jenkins/configuration/base/validate.go b/pkg/controller/jenkins/configuration/base/validate.go index ee7a8822..4ff7f27f 100644 --- a/pkg/controller/jenkins/configuration/base/validate.go +++ b/pkg/controller/jenkins/configuration/base/validate.go @@ -82,19 +82,19 @@ func (r *ReconcileJenkinsBaseConfiguration) validateImagePullSecret(name string) } if secret.Data["docker-server"] == nil { - r.logger.V(log.VWarn).Info("Docker Server is empty") + r.logger.V(log.VWarn).Info(fmt.Sprintf("Secret '%s' defined in spec.master.imagePullSecrets doesn't have 'docker-server' key.", name)) return false, nil } if secret.Data["docker-username"] == nil { - r.logger.V(log.VWarn).Info("Docker Username is empty") + r.logger.V(log.VWarn).Info(fmt.Sprintf("Secret '%s' defined in spec.master.imagePullSecrets doesn't have 'docker-username' key.", name)) return false, nil } if secret.Data["docker-password"] == nil { - r.logger.V(log.VWarn).Info("Docker Password is empty") + r.logger.V(log.VWarn).Info(fmt.Sprintf("Secret '%s' defined in spec.master.imagePullSecrets doesn't have 'docker-password' key.", name)) return false, nil } if secret.Data["docker-email"] == nil { - r.logger.V(log.VWarn).Info("Docker Email is empty") + r.logger.V(log.VWarn).Info(fmt.Sprintf("Secret '%s' defined in spec.master.imagePullSecrets doesn't have 'docker-email' key.", name)) return false, nil }