Cole Wippern
328847ffc2
Fix #925 broken insecure pull
2019-12-21 21:50:43 -08:00
Nao YONASHIRO
cbba7cec3f
chore: fix typo
2019-12-21 14:44:12 -08:00
Nao YONASHIRO
2599c0c69b
docs: fix wrong document
2019-12-21 14:42:58 -08:00
Cole Wippern
229820550e
Merge pull request #869 from prary/go_modules
...
changing to modules from dependencies
2019-12-21 12:56:15 -08:00
Cole Wippern
bdabd774fc
Update linter and fix errors
...
* disable linters that are now enabled by default in new version
* fix linter errors
2019-12-21 12:27:14 -08:00
Prashant Arya
976b4265fb
changing to modules from dependencies
2019-12-21 12:18:09 -08:00
Prashant Arya
85f1a5db00
Merge branch 'master' of https://github.com/GoogleContainerTools/kaniko into log
2019-12-19 03:20:56 +00:00
Cole Wippern
9e9b8a6e71
Fix #899 cached copy results in inconsistent key
...
* Update cached copy command to return the same result for
files used from context so that cached and uncached copy
commands produce the same cache key
* Update tests for fix
* Add test for cached run command key consistency
2019-12-15 10:23:31 -08:00
Cole Wippern
2aa481c15e
add unit tests for caching run and copy
2019-12-10 09:29:10 -08:00
Cole Wippern
b19214ad1e
Use cachekey not digest for COPY --from src
...
* use the cachekey of the src stage rather than the digest
for COPY --from commands as they are reproducible unlike digests
* track digest to cache keys and stage indexes to digest
* add extra debug logging for troubleshooting cachekey building issues
* convert Sha256 hashes to hex encoded strings rather than plain strings
for easier human reading
2019-12-10 08:45:13 -08:00
Cole Wippern
7b4b768edf
Update copy command cache key logic
...
Include the digest of the stage specified in the --from argument for
COPY commands which use --from
2019-12-09 16:48:20 -08:00
Tejal Desai
acb5b9f7c9
Merge pull request #839 from antechrestos/fix/upcase_for_from_stage_name
...
Fix failure when using capital letters in image alias in 'FROM ... AS…' instruction
2019-12-09 15:39:39 -08:00
Tejal Desai
03b1b1ce4c
Merge pull request #905 from poy/fixes/904
...
when copying, skip files with the same name
2019-12-09 13:07:13 -08:00
Tejal Desai
56f92e74af
Merge pull request #849 from wripley/master
...
Modified error message for writing image with digest file
2019-12-09 12:57:33 -08:00
poy
0a2f2957ec
when copying, skip files with the same name
...
When using the COPY command, if the source and destination have the same
the file should be skipped rather than copied. This is to prevent the
file from being overwritten and therefore producing an empty file.
fixes #904
2019-12-08 00:57:27 -07:00
Ben Einaudi
d22a7608c2
Fix failure when using capital letters in image alias in 'FROM ... AS' instruction
...
The third library moby/buildkit lowers the image alias used in 'FROM .. AS' instruction.
This change fixes this issue by making the resolve of dependencies agnostic to case.
Fixes #592
Fixes #770
2019-12-06 12:04:26 +01:00
Cole Wippern
7ba65daf7f
cleanup executor/build_test.go
2019-11-28 09:36:39 -08:00
Cole Wippern
828e764b95
add boilerplate for composite_cache_test
2019-11-28 09:18:58 -08:00
Cole Wippern
6d0c8da90e
more stagebuilder caching tests
2019-11-28 08:42:13 -08:00
Cole Wippern
33f3191b17
Don't hardcode hashes for stagebuilder tests
2019-11-27 21:47:00 -08:00
Cole Wippern
697037cbcf
Add unit tests for compositecache and stagebuilder
...
* add mock types for testing
* enhance error messaging
* add tests
2019-11-27 21:47:00 -08:00
Cole Wippern
54635c3d39
don't exit optimize early so we record cache keys
2019-11-27 17:09:00 -08:00
Cole Wippern
2755ae4470
Final cachekey for stage
...
Store the last cachekey generated for each stage
If the base image for a stage is present in the map of digest
and cachekeys use the retrieved cachekey instead of the base image
digest in the compositecache
2019-11-27 14:40:05 -08:00
Prashant Arya
857715012f
changing log level
2019-11-26 17:52:11 +00:00
Cole Wippern
bfd8562855
Merge pull request #879 from cvgw/u/cvgw/update_error_handling_and_logging_for_cache_retrieve
...
Update error handling and logging for cache
2019-11-23 10:20:40 -08:00
Cole Wippern
a6e458caf1
Update error handling and logging for cache
...
Previously we returned a low level file system error when checking for
a cached image. By adding a more human friendly log message and explicit
error handling we improve upon the user experience.
2019-11-22 14:54:38 -08:00
Cole Wippern
b057776849
Merge pull request #857 from cvgw/u/cgwippern/symlink-bug
...
Resolve symlink targets to abs path before copying
2019-11-22 10:02:58 -08:00
Cole Wippern
2b26dfea61
Add unit tests for resolveIfSymlink
2019-11-15 11:23:15 -08:00
Cole Wippern
2c13842451
Resolve symlink paths
2019-11-15 11:23:15 -08:00
Cole Wippern
50f1373837
Update Add command RequiresUnpackedFS
2019-11-15 11:23:15 -08:00
Cole Wippern
006b4996cb
Fix quote strip behavior for ARG values
...
* fixes issue 847
* previous implementation did not properly parse blank
values which were enclosed in quotes
2019-11-08 14:28:31 -08:00
Will Ripley
f6aa8f709b
Modified error message for writing image with digest file
2019-11-08 12:59:25 -06:00
Tejal Desai
1d5e294f27
Merge pull request #841 from wripley/master
...
Added --image-name-with-digest flag
2019-11-08 08:24:26 -08:00
Tejal Desai
b04d15db82
fix the issue now
2019-11-07 15:29:56 -08:00
Tejal Desai
f36dd4013c
only add tests
2019-11-07 15:17:25 -08:00
Tejal Desai
334f0c70d6
fix golint
2019-11-07 15:11:29 -08:00
Tejal Desai
b29431227a
fix tests for default home
2019-11-07 15:07:50 -08:00
Tejal Desai
5bbb40e4f0
Merge pull request #834 from cvgw/u/cgwippern/ISSUE_439_strip_arg_quotes
...
Issue #439 Strip out double quotes in ARG value
2019-11-07 10:54:17 -08:00
Don McCasland
5716c44ab8
Merge branch 'master' into bug-742-2
2019-11-04 09:25:25 -08:00
Will Ripley
c8f089fdbb
Fixed formatting errors with push.go and push_test.go
2019-10-29 13:09:27 -05:00
Will Ripley
a0651436b5
Changed image name to be full image name minus tag. Also added test for new ImageNameDigestFile flag
2019-10-29 12:55:50 -05:00
Will Ripley
c2faa4e5e6
Fixed spacing issue in config
2019-10-29 11:04:33 -05:00
Will Ripley
08d0948510
Merge remote-tracking branch 'upstream/master'
2019-10-29 11:02:16 -05:00
Will Ripley
f38c47daa0
Made changes to --image-name-with-digest-file to support multiple destinations
2019-10-29 10:55:49 -05:00
Cole Wippern
0ce287d95c
ISSUE #439 ci lint
2019-10-25 16:27:14 -07:00
Cole Wippern
ec2e7705c8
Issue #439 add additional tests for quotes
...
Add additional tests to ensure that ARG values with quotes
are handled properly
2019-10-25 16:08:57 -07:00
Tejal Desai
c5bc179c85
Merge pull request #816 from yangtaokm/azure-blobstorage-https
...
[WIP] Add support to download context file from Azure Blob Storage
2019-10-25 10:51:50 -07:00
Cole Wippern
79649a1614
Issue #439 double quotes in ARG value
...
* Strip out double quotes enclosing ARG value after parsing
dockerfile
2019-10-24 16:30:25 -07:00
yangtaokm
aa881d59cb
fix gofmt
2019-10-22 17:10:08 +08:00
yangtaokm
45c43a2c89
refactory the code and add CreateTargetTarfile in fs_util.go
2019-10-22 16:44:51 +08:00