public_git
/
kaniko
mirror of https://github.com/GoogleContainerTools/kaniko
1
0
Fork 0
Code Issues Releases Wiki Activity

only add tests

This commit is contained in:
Tejal Desai 2019-11-07 15:17:25 -08:00
parent 334f0c70d6
commit f36dd4013c
2 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/commands/run.go
View File

@ -141,10 +141,7 @@ func addDefaultHOME(u string, envs []string) []string {
home := fmt.Sprintf("%s=/", constants.HOME)
userObj, err := userLookup(u)
if err == nil {
u = userObj.HomeDir
if u == "" {
u = userObj.Username
}
u = userObj.Username
home = fmt.Sprintf("%s=/home/%s", constants.HOME, u)
}

12
pkg/commands/run_test.go
View File

@ -43,7 +43,7 @@ func Test_addDefaultHOME(t *testing.T) {
},
},
{
name: "HOME isn't set, user isn't set",
name: "HOME not set, user not set",
user: "",
initial: []string{
"PATH=/something/else",
@ -54,7 +54,7 @@ func Test_addDefaultHOME(t *testing.T) {
},
},
{
name: "HOME isn't set, user and homedir for the user set",
name: "HOME not set, user and homedir for the user set",
user: "www-add",
mockUser: &user.User{
Username: "www-add",
@ -65,11 +65,11 @@ func Test_addDefaultHOME(t *testing.T) {
},
expected: []string{
"PATH=/something/else",
"HOME=/home/some-other",
"HOME=/home/www-add",
},
},
{
name: "HOME isn't set, user set",
name: "HOME not set, user set",
user: "www-add",
mockUser: &user.User{
Username: "www-add",
@ -83,7 +83,7 @@ func Test_addDefaultHOME(t *testing.T) {
},
},
{
name: "HOME isn't set, user is set",
name: "HOME not set, user is set",
user: "newuser",
mockUser: &user.User{
Username: "newuser",
@ -97,7 +97,7 @@ func Test_addDefaultHOME(t *testing.T) {
},
},
{
name: "HOME isn't set, user is set to root",
name: "HOME not set, user is set to root",
user: "root",
mockUser: &user.User{
Username: "root",