adding LABEL command

This commit is contained in:
sharifelgamal 2018-03-21 11:34:37 -07:00
parent c168125c69
commit ba77ba0822
No known key found for this signature in database
GPG Key ID: 63E3F6ED6963163C
4 changed files with 94 additions and 1 deletions

View File

@ -42,6 +42,8 @@ func GetCommand(cmd instructions.Command) (DockerCommand, error) {
return &ExposeCommand{cmd: c}, nil
case *instructions.EnvCommand:
return &EnvCommand{cmd: c}, nil
case *instructions.LabelCommand:
return &LabelCommand{cmd: c}, nil
}
return nil, errors.Errorf("%s is not a supported command", cmd.Name())
}

View File

@ -69,6 +69,6 @@ func (r *ExposeCommand) FilesToSnapshot() []string {
}
func (r *ExposeCommand) CreatedBy() string {
s := []string{"/bin/sh", "-c"}
s := []string{r.cmd.Name()}
return strings.Join(append(s, r.cmd.Ports...), " ")
}

57
pkg/commands/label.go Normal file
View File

@ -0,0 +1,57 @@
/*
Copyright 2018 Google LLC
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package commands
import (
"github.com/containers/image/manifest"
"github.com/docker/docker/builder/dockerfile/instructions"
"github.com/sirupsen/logrus"
"strings"
)
type LabelCommand struct {
cmd *instructions.LabelCommand
}
func (r *LabelCommand) ExecuteCommand(config *manifest.Schema2Config) error {
return updateLabels(r.cmd.Labels, config)
}
func updateLabels(labels []instructions.KeyValuePair, config *manifest.Schema2Config) error {
existingLabels := config.Labels
for _, kvp := range labels {
logrus.Infof("Applying label %s=%s", kvp.Key, kvp.Value)
existingLabels[kvp.Key] = kvp.Value
}
config.Labels = existingLabels
return nil
}
func (r *LabelCommand) FilesToSnapshot() []string {
return []string{}
}
func (r *LabelCommand) CreatedBy() string {
l := []string{r.cmd.Name()}
for _, kvp := range r.cmd.Labels {
l = append(l, kvp.String())
}
return strings.Join(l, " ")
}

View File

@ -0,0 +1,34 @@
package commands
import (
"github.com/GoogleCloudPlatform/k8s-container-builder/testutil"
"github.com/containers/image/manifest"
"github.com/docker/docker/builder/dockerfile/instructions"
"testing"
)
func TestUpdateLabels(t *testing.T) {
cfg := &manifest.Schema2Config{
Labels: map[string]string {
"foo": "bar",
},
}
labels := []instructions.KeyValuePair{
{
Key: "foo",
Value: "override",
},
{
Key: "bar",
Value: "baz",
},
}
expectedLabels := map[string]string {
"foo": "override",
"bar": "baz",
}
updateLabels(labels, cfg)
testutil.CheckErrorAndDeepEqual(t, false, nil, expectedLabels, cfg.Labels)
}