Merge pull request #112 from priyawadhwa/maintainer

Skip maintainer command

integration_tests/dockerfiles/Dockerfile_test_run_2

@@ -17,3 +17,4 @@
 
 FROM gcr.io/google-appengine/debian9
 RUN echo "hey" 
+MAINTAINER kaniko

integration_tests/integration_test_yaml.go

@@ -182,7 +182,8 @@ type step struct {
 }
 
 type testyaml struct {
-	Steps []step
+	Steps   []step
+	Timeout string
 }
 
 func main() {
@@ -232,6 +233,7 @@ func main() {
 	y := testyaml{
 		Steps: []step{containerDiffStep, containerDiffPermissions, structureTestsStep, structureTestPermissions, GCSBucketTarBuildContext, uploadTarBuildContext, buildExecutorImage,
 			buildOnbuildImage, pushOnbuildBase},
+		Timeout: "1200s",
 	}
 	for _, test := range fileTests {
 		// First, build the image with docker

pkg/commands/commands.go

@@ -20,6 +20,7 @@ import (
 	"github.com/containers/image/manifest"
 	"github.com/docker/docker/builder/dockerfile/instructions"
 	"github.com/pkg/errors"
+	"github.com/sirupsen/logrus"
 )
 
 type DockerCommand interface {
@@ -60,6 +61,9 @@ func GetCommand(cmd instructions.Command, buildcontext string) (DockerCommand, e
 		return &OnBuildCommand{cmd: c}, nil
 	case *instructions.VolumeCommand:
 		return &VolumeCommand{cmd: c}, nil
+	case *instructions.MaintainerCommand:
+		logrus.Warnf("%s is deprecated, skipping", cmd.Name())
+		return nil, nil
 	}
 	return nil, errors.Errorf("%s is not a supported command", cmd.Name())
 }

pkg/executor/executor.go

@@ -85,6 +85,9 @@ func DoBuild(dockerfilePath, srcContext, destination, snapshotMode string) error
 			if err != nil {
 				return err
 			}
+			if dockerCommand == nil {
+				continue
+			}
 			if err := dockerCommand.ExecuteCommand(imageConfig); err != nil {
 				return err
 			}