mirror of
https://github.com/helmfile/helmfile.git
synced 2026-09-30 20:33:16 +02:00
Danny Shemesh
ceb108a24f
Fixes https://github.com/roboll/helmfile/issues/1142 desired_state_file_loader.go - Will now normalize the content before splitting it to parts context: Me & and a fellow dev have tried to figure out why helmfile didn't fill in certain values on his machine; turns out, he'd mistakenly checked out our project w/ CRLF line endings, which had caused part splitting to not work (as it's hard coded to look for '\n'). The following was acted on as a single part, causing values from the bases not to be available in the next yaml part: ``` bases:\r\n - base.yaml\r\n ---\r\n releases: - name: external-secrets-crd ... some templated yaml ... ``` I've thought about regex-ing it out instead of replace-all, but benchmarks had shown that a plain replace is faster. I've also considered splitting by "\n---" instead of "\n---", but that would break if the dashes were to continue with some other text.