helmfile/pkg
Danny Shemesh ceb108a24f
Fixed part splitting for CLRF separated files (#1265)
Fixes https://github.com/roboll/helmfile/issues/1142

desired_state_file_loader.go
- Will now normalize the content before splitting it to parts

context:
Me & and a fellow dev have tried to figure out why helmfile didn't fill in certain values on his machine; 
turns out, he'd mistakenly checked out our project w/ CRLF line endings, which had caused part splitting to not work (as it's hard coded to look for '\n').

The following was acted on as a single part, causing values from the bases not to be available in the next yaml part:

```
bases:\r\n
  - base.yaml\r\n
---\r\n

releases:
  - name: external-secrets-crd
    ... some templated yaml ...
```

I've thought about regex-ing it out instead of replace-all, but benchmarks had shown that a plain replace is faster.

I've also considered splitting by "\n---" instead of "\n---", but that would break if the dashes were to continue with some other text.
2020-05-19 10:04:12 +09:00
..
app Fixed part splitting for CLRF separated files (#1265) 2020-05-19 10:04:12 +09:00
argparser fix: helmDefaults.kubeContext ignored in `helm diff` of `helmfile apply` (#682) 2019-06-12 16:49:19 +09:00
environment Fix: populate .Values regardless of prestate success (#1202) 2020-04-17 09:18:01 +09:00
event feat: Enhance postsync event to include `.Error` (#882) 2019-10-17 08:27:12 +09:00
exectest Support for createNamespace (#1226) 2020-04-26 10:41:40 +09:00
helmexec Show executed command when errors occurred (#1252) 2020-05-09 13:35:31 +09:00
maputil Add indexed key support to --state-values-set (#1042) 2019-12-17 07:31:42 +09:00
plugins feat(template): added secret template function (#1221) 2020-04-25 21:10:02 +09:00
remote Fix recursion for helmfiles pulled from git (#854) 2019-09-14 05:49:59 +02:00
state Optionally error when subhelmfiles do not exist (#1245) 2020-05-12 09:41:39 +09:00
testhelper fix: Fix `needs` to work for upgrades and when selectors are provided (#922) 2019-11-02 14:04:16 +09:00
tmpl feat(template): added secret template function (#1221) 2020-04-25 21:10:02 +09:00