a8b30c1f0f
Merge 9187d4ed91 into 55adae872e
2025-10-23 22:02:12 -04:00
391c677058
Avoid fetching same chart/version multiple times ( #2197 )
...
* Initial plan
* Implement chart fetch deduplication mechanism
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
* Fix CI issues: resolve gci formatting and reduce cognitive complexity
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
* Remove redundant Fetching log message from OCI chart processing
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
2025-10-10 12:13:29 +08:00
6673ebad84
fix: skip chartify for build command jsonPatches ( #2212 )
...
The build command is intended to be a read-only inspection command that
outputs the helmfile state. However, when releases use jsonPatches,
strategicMergePatches, or transformers, the chart preparation step
triggers chartify, which runs helm template and requires dependencies to
be built.
This causes two issues:
1. helm template is executed unnecessarily for a simple state inspection
2. Missing chart dependencies cause errors even with SkipDeps enabled
This change modifies PrepareCharts to filter out releases that require
chartify when the command is "build". These releases are excluded from
chart preparation, preventing helm template from being invoked.
The state output will still include these releases, but their charts
won't be processed during the build operation.
Signed-off-by: Shane Starcher <shanestarcher@gmail.com>
2025-10-05 07:39:54 +08:00
422ac1ecef
Apply suggestions from Copilot code review
...
Signed-off-by: Simon Bouchard <sbouchard@rbbn.com>
2025-09-19 20:19:41 -04:00
32afe9de42
Merge branch 'main' into update-strategy-feature
2025-09-19 14:41:54 -04:00
d646b3cbd4
feat: Implement caching for pulling OCI charts ( #2171 )
...
Signed-off-by: Ruslan Khizhnyak <mustdiechik@gmail.com>
Co-authored-by: Ruslan Khizhnyak <rkhizhnyak@ptsecurity.com>
2025-09-13 12:49:03 +08:00
3728b6f647
Remove deprecated --wait-retries flag support to fix Helm compatibility error ( #2179 )
...
* Remove --wait-retries flag support and update documentation
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
* Fix unused helm parameter in appendWaitFlags function
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
2025-09-11 13:57:28 +08:00
a9594eb158
Fix error propagation in helmfile diff when Kubernetes is unreachable ( #2149 )
...
* Fix error propagation in helmfile diff when Kubernetes is unreachable
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
* Fix golangci-lint issue: replace custom contains function with strings.Contains
Co-authored-by: zhaque44 <20215376+zhaque44@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
Co-authored-by: zhaque44 <20215376+zhaque44@users.noreply.github.com>
2025-09-02 12:51:17 -04:00
d37f937c9e
Fix enableDNS flag missing in diff command and refactor duplicate logic ( #2147 )
...
* Initial plan
* Add enableDNS flag support to diff command
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
* Extract EnableDNS flag logic into reusable function
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
2025-08-27 14:32:17 +08:00
135ff63aa3
Add missing --timeout flag to helmfile sync command with documentation ( #2148 )
...
* Initial plan
* Implement --timeout flag for helmfile sync command
- Add Timeout field to SyncOptions struct in pkg/config/sync.go
- Add --timeout flag to sync command in cmd/sync.go
- Add Timeout field to SyncOpts struct in pkg/state/state.go
- Modify timeoutFlags() function to prioritize CLI timeout over release and default configs
- Add test case to verify CLI timeout overrides other timeout settings
- Follow same pattern as existing --wait and --wait-for-jobs flags
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
* Fix lint issues: format test struct fields properly
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
* Update docs: Add --timeout flag documentation for helmfile sync command
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
2025-08-27 14:32:02 +08:00
8c123dcdda
refactor(state): extract getMissingFileHandler method for clarity ( #2133 )
...
* refactor(state): extract getMissingFileHandler method for clarity
Signed-off-by: yxxhero <aiopsclub@163.com>
2025-08-14 21:10:44 +08:00
eca333c0eb
Make sure to add --wait when deleting a release to be reinstalled due to reinstallIfForbidden
...
Signed-off-by: Simon Bouchard <sbouchard@rbbn.com>
2025-08-05 11:24:26 -04:00
94de61b951
Display affected releases that were reinstalled
...
Signed-off-by: Simon Bouchard <sbouchard@rbbn.com>
2025-08-02 16:47:09 -04:00
e3c0d3b770
Removed 'reinstall' update strategy option to only have reinstallIfForbidden, cleanup of pre-sync changes, adapted unit tests
...
Signed-off-by: Simon Bouchard <sbouchard@rbbn.com>
2025-08-02 16:21:27 -04:00
9a6aa9e52b
Merge branch 'update-strategy-feature' of https://github.com/simbou2000/helmfile into update-strategy-feature
...
Signed-off-by: Simon Bouchard <sbouchard@rbbn.com>
2025-07-29 19:36:45 -04:00
88d58363e8
Merge branch 'main' into update-strategy-feature
2025-07-29 19:14:59 -04:00
c10bb1c4e0
Add validation of updateStrategy parameter and unit test
...
Signed-off-by: Simon Bouchard <sbouchard@rbbn.com>
2025-07-29 18:02:20 -04:00
a76bec234c
refactor(filesystem): add CopyDir method and optimize Fetch function ( #2111 )
...
* refactor(filesystem): add CopyDir method and optimize Fetch function
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix(state): conditionally prepare charts for local helmfile command
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix(state): conditionally prepare charts for local helmfile command
Signed-off-by: yxxhero <aiopsclub@163.com>
* refactor(state): optimize chart path generation and update dependencies
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix(test): update path in fetch-forl-local-chart test
Signed-off-by: yxxhero <aiopsclub@163.com>
* add more test cases
Signed-off-by: yxxhero <aiopsclub@163.com>
---------
Signed-off-by: yxxhero <aiopsclub@163.com>
2025-07-28 16:10:25 -04:00
b0911ab1a2
feat(state): add missingFileHandlerConfig and related logic ( #2105 )
...
* feat(state): add missingFileHandlerConfig and related logic
Signed-off-by: yxxhero <aiopsclub@163.com>
* feat(state): add missingFileHandlerConfig and related logic
Signed-off-by: yxxhero <aiopsclub@163.com>
---------
Signed-off-by: yxxhero <aiopsclub@163.com>
2025-07-21 19:15:51 -04:00
767cdb9497
Merge branch 'main' into update-strategy-feature
...
Signed-off-by: Simon Bouchard <sbouchard@rbbn.com>
2025-04-28 10:25:40 -04:00
c3864a45d3
feat: add --take-ownership flag to helm diff and related config ( #1992 )
...
* feat: add --take-ownership flag to helm diff and related config
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix: nil issue
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix more issue
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix more issues
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* add more tests
Signed-off-by: yxxhero <aiopsclub@163.com>
---------
Signed-off-by: yxxhero <aiopsclub@163.com>
2025-04-27 12:57:41 -04:00
aaef5c98f8
Resolve linter issue due to cognitive complexity
...
Signed-off-by: Simon Bouchard <sbouchard@rbbn.com>
2025-04-25 15:51:50 -04:00
ec70bc5b2d
feat: Add updateStrategy option in the state file with 'reinstall'/'reinstallIfForbidden' choices to uninstall and apply the specific release(s) (if forbidden to update)
...
Signed-off-by: Simon Bouchard <sbouchard@rbbn.com>
2025-04-24 18:10:36 -04:00
9bf51cb011
Feat: setting reuseValues flag in release ( #2004 )
...
* Feat: reuseValues in release
Adding properties to set reuseValues flag on release-level.
Signed-off-by: Adam Blasko <adam.blasko1@gmail.com>
* feat: fixing tests
Most of the tests had issues with flag order, which changed due to moving the value control flags out of the "common flags" for diff
Signed-off-by: Adam Blasko <adam.blasko1@gmail.com>
* fix: fixing lint issue
Signed-off-by: Adam Blasko <adam.blasko1@gmail.com>
---------
Signed-off-by: Adam Blasko <adam.blasko1@gmail.com>
2025-04-23 07:53:29 +08:00
c9a2e76200
fix: Check needs with context and namespace ( #1986 )
...
* fix: Check needs with context and namespace
Signed-off-by: André Arnqvist <andrearnqvist@gmail.com>
* fix: Ensure releases have overrides
Signed-off-by: André Arnqvist <andrearnqvist@gmail.com>
* fix: Run go fmt
Signed-off-by: André Arnqvist <andrearnqvist@gmail.com>
* fix: Add tests checking needs with same name in different namespaces
Signed-off-by: André Arnqvist <andrearnqvist@gmail.com>
* fix: Simplify setting overrides
Signed-off-by: André Arnqvist <andrearnqvist@gmail.com>
---------
Signed-off-by: André Arnqvist <andrearnqvist@gmail.com>
2025-04-07 21:57:02 +08:00
e4273d050e
feat: add labels for helm release ( #1046 )
...
feat: add labels for k8s resources
Signed-off-by: yxxhero <aiopsclub@163.com>
2025-03-30 19:24:41 -04:00
d26d909a5e
build(deps): bump golangci/golangci-lint-action from 6 to 7 ( #1975 )
...
* build(deps): bump golangci/golangci-lint-action from 6 to 7
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 6 to 7.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](https://github.com/golangci/golangci-lint-action/compare/v6...v7 )
---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* refactor(.github/workflows/ci.yaml): update golangci-lint version to v2.0.2
Signed-off-by: yxxhero <aiopsclub@163.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: yxxhero <aiopsclub@163.com>
2025-03-28 07:52:06 +08:00
5d29f03782
Remove all v0.x references ( #1919 )
...
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* refactor(two_pass_renderer): remove unused imports and functions
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
---------
Signed-off-by: yxxhero <aiopsclub@163.com>
2025-03-08 07:43:21 -06:00
410d84bba5
Don't warn if this and the needed release set installed: false ( #1958 )
...
When the evaluated release has installed: false it's perfectly fine that
a needed release is installed: false as well.
fixes #1464
Signed-off-by: jayme-github <jayme-github@users.noreply.github.com>
2025-03-06 22:52:26 +08:00
a89803521d
refactor(state): optimize HelmState flags handling ( #1937 )
...
Signed-off-by: yxxhero <aiopsclub@163.com>
2025-02-15 12:17:44 +08:00
8b15c30cf2
docs: add skipSchemaValidation to index.md and update related structs ( #1935 )
...
* docs: add skipSchemaValidation to index.md and update related structs
Signed-off-by: yxxhero <aiopsclub@163.com>
* feat: add SkipSchemaValidation to config and state handling
Signed-off-by: yxxhero <aiopsclub@163.com>
---------
Signed-off-by: yxxhero <aiopsclub@163.com>
2025-02-14 11:57:50 -05:00
2c38611acd
feat: Add support for --wait-retries flag. ( #1922 )
...
* feat: Add support for --wait-retries flag.
This change wires up waitRetries option to set the helm --wait-retries flag.
--wait-retries was added in helm 3.15.0 and makes waiting more robust to registry errors.
https://github.com/helm/helm/commit/fc74964
https://github.com/helm/helm/releases/tag/v3.15.0
Resolves #1522
Signed-off-by: Connor Hindley <connor.hindley@tanium.com>
2025-02-12 07:28:37 +08:00
63e2684ade
Revert "cleanup: remove all about v0.x" ( #1918 )
...
Revert "cleanup: remove all about v0.x (#1903 )"
This reverts commit d7bcd5e998
2025-02-08 18:25:16 +08:00
d7bcd5e998
cleanup: remove all about v0.x ( #1903 )
...
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* refactor(two_pass_renderer): remove unused imports and functions
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix tests
Signed-off-by: yxxhero <aiopsclub@163.com>
---------
Signed-off-by: yxxhero <aiopsclub@163.com>
2025-02-05 13:50:16 -05:00
d059b28fb3
Ensure 'helm repo add' is also not pollute on helmfile template ( #1887 )
...
When having multiple helmfiles in one helmfile.d folder and multiple of
them having repositories defined, the errors mention in #1749 still
existed.
Fixes #1749 (again)
Signed-off-by: Matthias Baur <m.baur@syseleven.de>
2025-01-22 20:42:33 +08:00
afe18e8031
feat: Add "--no-hooks" to helmfile template ( #1813 )
...
* Adding support for no-hooks in template cmd
Signed-off-by: Justin Lai <justin.lai@invitae.com>
2025-01-15 13:33:16 +08:00
2333f093c1
fix: ensure development versions of charts can be used across helmfile commands ( #1865 )
...
Signed-off-by: purpleclay <purpleclaygh@gmail.com>
2025-01-13 20:55:23 +08:00
2e21e2fa0b
fix: ensure plain http is supported across all helmfile commands ( #1858 )
...
fix: ensure plain http is supported across helmfile commands
Signed-off-by: purpleclay <purpleclaygh@gmail.com>
2025-01-12 15:31:12 +08:00
22ad21c1ae
feat: add --take-ownership flag to apply and sync commands ( #1863 )
...
Signed-off-by: yxxhero <aiopsclub@163.com>
2025-01-11 08:41:10 -06:00
bd12fa1cc3
feat(state): add support for setString in ReleaseSpec and HelmState ( #1821 )
...
* feat(state): add support for setString in ReleaseSpec and HelmState
Signed-off-by: yxxhero <aiopsclub@163.com>
* docs: add setString section to index.md for helm configuration
Signed-off-by: yxxhero <aiopsclub@163.com>
* tests: fix more tests
Signed-off-by: yxxhero <aiopsclub@163.com>
---------
Signed-off-by: yxxhero <aiopsclub@163.com>
2024-12-09 10:37:56 -05:00
8891439cdc
fix: inject global values in Chartify ( #1805 )
...
* fix: inject global values in Chartify
Signed-off-by: Thomas Loubiou <thomas.loubiou@mirakl.com>
* test: add integration tests for template --values
Signed-off-by: Thomas Loubiou <thomas.loubiou@mirakl.com>
---------
Signed-off-by: Thomas Loubiou <thomas.loubiou@mirakl.com>
2024-12-04 18:51:21 +08:00
1464bd2bfa
feat: refactor label creation in state.go ( #1758 )
...
* feat: refactor label creation in state.go
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix more
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix test
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix more issue
Signed-off-by: yxxhero <aiopsclub@163.com>
---------
Signed-off-by: yxxhero <aiopsclub@163.com>
2024-11-10 18:28:01 -05:00
d23dc8a9de
Add integration tests for #1749 ( #1766 )
...
* Add integration tests for #1749
Signed-off-by: Matthias Baur <m.baur@syseleven.de>
* Reset extra args on a higher level to only affect subsequent helmfiles
With the implementation before, extra args has been reset after each
helm.exec which leads to problems with multiple charts in a helmfile
since the correct args are only set once in Template(). But Template()
calls helm.exec(template) multiple times.
Signed-off-by: Matthias Baur <m.baur@syseleven.de>
---------
Signed-off-by: Matthias Baur <m.baur@syseleven.de>
2024-11-06 08:12:20 +08:00
d1416ec7b4
feat: add skip json schema validation during the install /upgrade of a Chart ( #1737 )
...
* open PR for --skip-schema-validation flag
Signed-off-by: zhaque44 <haque.zubair@gmail.com>
2024-10-24 20:53:18 +08:00
dea501cb10
[feature] --skip-refresh to pass through to deps ( #1740 )
...
--skip-refresh right now disables adding new repos, but in addition it
should pass down to helm deps update to not refresh the actual values
Signed-off-by: Shane Starcher <shane.starcher@gmail.com>
Co-authored-by: Shane Starcher <shane.starcher@gmail.com>
2024-10-15 22:26:59 +08:00
fbf40b600f
feat: improve summary for releases failed to delete ( #1735 )
...
Signed-off-by: Felipe Santos <felipecassiors@gmail.com>
2024-10-14 10:49:05 -04:00
b6ab825d3c
[feature] add --skip-refresh to globals ( #1736 )
2024-10-12 19:56:55 +08:00
4beb2ac042
fix: duration of delete failures are always 0s ( #1734 )
2024-10-12 06:58:38 +08:00
b375a31f20
feat: update go version and adjust dependencies in Dockerfile and go.mod ( #1722 )
...
* feat: update go version and adjust dependencies in Dockerfile and go.mod
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix lint
Signed-off-by: yxxhero <aiopsclub@163.com>
* fix lint
Signed-off-by: yxxhero <aiopsclub@163.com>
---------
Signed-off-by: yxxhero <aiopsclub@163.com>
2024-09-30 09:21:44 -04:00
8988892c53
build(deps): bump dario.cat/mergo from 0.3.16 to 1.0.1 ( #1714 )
...
Signed-off-by: yxxhero <aiopsclub@163.com>
2024-09-19 18:47:24 -05:00
Simon Bouchard
Copilot
Shane Starcher
Simon Bouchard
Ruslan
yxxhero
Adam Blasko
André Arnqvist
dependabot[bot]
jayme-github
Connor Hindley
Matthias Baur
Justin Lai
Purple Clay
Thomas Loubiou
Zubair Haque
Felipe Santos