Don't warn if this and the needed release set installed: false (#1958)

When the evaluated release has installed: false it's perfectly fine that
a needed release is installed: false as well.

fixes #1464

Signed-off-by: jayme-github <jayme-github@users.noreply.github.com>

pkg/app/testdata/app_diff_test_1/delete_foo_and_bar_when_bar_needs_foo

@@ -34,7 +34,6 @@ second-pass rendering result of "helmfile.yaml.part.0":
 10: 
 
 merged environment: &{default  map[] map[]}
-WARNING: release bar needs foo, but foo is not installed due to installed: false. Either mark foo as installed or remove foo from bar's needs
 2 release(s) found in helmfile.yaml
 
 Affected releases are:

pkg/app/testdata/app_diff_test_1/delete_foo_and_bar_when_foo_needs_bar

@@ -34,7 +34,6 @@ second-pass rendering result of "helmfile.yaml.part.0":
 10: 
 
 merged environment: &{default  map[] map[]}
-WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 2 release(s) found in helmfile.yaml
 
 Affected releases are:

pkg/app/testdata/app_diff_test_1/smoke

@@ -122,7 +122,6 @@ second-pass rendering result of "helmfile.yaml.part.0":
 54: 
 
 merged environment: &{default  map[] map[]}
-WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 10 release(s) found in helmfile.yaml
 
 processing 5 groups of releases in this order:

pkg/app/testdata/app_diff_test_2/delete_foo_and_bar_when_bar_needs_foo

@@ -34,7 +34,6 @@ second-pass rendering result of "helmfile.yaml.part.0":
 10: 
 
 merged environment: &{default  map[] map[]}
-WARNING: release bar needs foo, but foo is not installed due to installed: false. Either mark foo as installed or remove foo from bar's needs
 2 release(s) found in helmfile.yaml
 
 Affected releases are:

pkg/app/testdata/app_diff_test_2/delete_foo_and_bar_when_foo_needs_bar

@@ -34,7 +34,6 @@ second-pass rendering result of "helmfile.yaml.part.0":
 10: 
 
 merged environment: &{default  map[] map[]}
-WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 2 release(s) found in helmfile.yaml
 
 Affected releases are:

pkg/app/testdata/app_diff_test_2/smoke

@@ -122,7 +122,6 @@ second-pass rendering result of "helmfile.yaml.part.0":
 54: 
 
 merged environment: &{default  map[] map[]}
-WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 10 release(s) found in helmfile.yaml
 
 processing 5 groups of releases in this order:

pkg/app/testdata/testapply/delete_foo_and_bar_when_bar_needs_foo/log

@@ -34,7 +34,6 @@ second-pass rendering result of "helmfile.yaml.part.0":
 10: 
 
 merged environment: &{default  map[] map[]}
-WARNING: release bar needs foo, but foo is not installed due to installed: false. Either mark foo as installed or remove foo from bar's needs
 2 release(s) found in helmfile.yaml
 
 Affected releases are:

pkg/app/testdata/testapply/delete_foo_and_bar_when_foo_needs_bar/log

@@ -34,7 +34,6 @@ second-pass rendering result of "helmfile.yaml.part.0":
 10: 
 
 merged environment: &{default  map[] map[]}
-WARNING: release foo needs bar, but bar is not installed due to installed: false. Either mark bar as installed or remove bar from foo's needs
 2 release(s) found in helmfile.yaml
 
 Affected releases are:

pkg/app/testdata/testapply/smoke/log

@@ -122,7 +122,6 @@ second-pass rendering result of "helmfile.yaml.part.0":
 54: 
 
 merged environment: &{default  map[] map[]}
-WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 10 release(s) found in helmfile.yaml
 
 Affected releases are:

pkg/app/testdata/testdestroy/destroy_only_one_release_with_selector/log

@@ -122,7 +122,6 @@ second-pass rendering result of "helmfile.yaml.part.0":
 54: 
 
 merged environment: &{default  map[] map[]}
-WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 1 release(s) matching name=logging found in helmfile.yaml
 
 processing 1 groups of releases in this order:

pkg/app/testdata/testdestroy/smoke/log

@@ -122,7 +122,6 @@ second-pass rendering result of "helmfile.yaml.part.0":
 54: 
 
 merged environment: &{default  map[] map[]}
-WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 10 release(s) found in helmfile.yaml
 
 processing 5 groups of releases in this order:
@@ -136,7 +135,6 @@ GROUP RELEASES
 processing releases in group 1/5: default//frontend-v3, default//frontend-v2, default//frontend-v1
 release "frontend-v3" processed
 release "frontend-v2" processed
-WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 release "frontend-v1" processed
 processing releases in group 2/5: default//backend-v2, default//backend-v1
 release "backend-v2" processed

pkg/app/testdata/testdestroy_2/destroy_only_one_release_with_selector/log

@@ -122,7 +122,6 @@ second-pass rendering result of "helmfile.yaml.part.0":
 54: 
 
 merged environment: &{default  map[] map[]}
-WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 1 release(s) matching name=logging found in helmfile.yaml
 
 processing 1 groups of releases in this order:

pkg/app/testdata/testdestroy_2/smoke/log

@@ -122,7 +122,6 @@ second-pass rendering result of "helmfile.yaml.part.0":
 54: 
 
 merged environment: &{default  map[] map[]}
-WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 10 release(s) found in helmfile.yaml
 
 processing 5 groups of releases in this order:
@@ -136,7 +135,6 @@ GROUP RELEASES
 processing releases in group 1/5: frontend-v3, frontend-v2, frontend-v1
 release "frontend-v3" processed
 release "frontend-v2" processed
-WARNING: release frontend-v1 needs backend-v1, but backend-v1 is not installed due to installed: false. Either mark backend-v1 as installed or remove backend-v1 from frontend-v1's needs
 release "frontend-v1" processed
 processing releases in group 2/5: backend-v2, backend-v1
 release "backend-v2" processed

pkg/state/state.go

@@ -502,7 +502,7 @@ func (st *HelmState) reformat(spec *ReleaseSpec) []string {
 		components := strings.Split(n, "/")
 
 		name = components[len(components)-1]
-		if !releaseInstalledInfo[name] {
+		if spec.Desired() && !releaseInstalledInfo[name] {
 			st.logger.Warnf("WARNING: %s", fmt.Sprintf("release %s needs %s, but %s is not installed due to installed: false. Either mark %s as installed or remove %s from %s's needs", spec.Name, name, name, name, name, spec.Name))
 		}