Merge pull request #441 from helmfile/move_upgrade_notice_env_into_envvar

This commit is contained in:
yxxhero
2022-10-20 05:18:19 +08:00
committed by GitHub
2 changed files with 3 additions and 1 deletions
+2 -1
View File
@@ -12,6 +12,7 @@ import (
"github.com/helmfile/helmfile/pkg/app"
"github.com/helmfile/helmfile/pkg/app/version"
"github.com/helmfile/helmfile/pkg/config"
"github.com/helmfile/helmfile/pkg/envvar"
"github.com/helmfile/helmfile/pkg/errors"
"github.com/helmfile/helmfile/pkg/helmexec"
)
@@ -75,7 +76,7 @@ func NewRootCmd(globalConfig *config.GlobalOptions, args []string) (*cobra.Comma
// when set environment HELMFILE_UPGRADE_NOTICE_DISABLED any value, skip upgrade notice.
var versionOpts []extension.CobraOption
if os.Getenv("HELMFILE_UPGRADE_NOTICE_DISABLED") == "" {
if os.Getenv(envvar.UpgradeNoticeDisabled) == "" {
versionOpts = append(versionOpts, extension.WithUpgradeNotice("helmfile", "helmfile"))
}
+1
View File
@@ -6,3 +6,4 @@ const Experimental = "HELMFILE_EXPERIMENTAL" // environment variable for experim
const Environment = "HELMFILE_ENVIRONMENT"
const TempDir = "HELMFILE_TEMPDIR"
const Helm3 = "HELMFILE_HELM3"
const UpgradeNoticeDisabled = "HELMFILE_UPGRADE_NOTICE_DISABLED"