mirror of
https://github.com/helmfile/helmfile.git
synced 2026-10-01 17:01:29 +02:00
fix the bug that resulted in helmfile sync not delete releases with --namespace
This commit is contained in:
+6
-13
@@ -914,19 +914,12 @@ func (a *App) sync(r *Run, c SyncConfigProvider) (bool, []error) {
|
||||
return false, errs
|
||||
}
|
||||
|
||||
var toSync []state.ReleaseSpec
|
||||
|
||||
if len(st.Selectors) > 0 {
|
||||
var err error
|
||||
toSync, err = st.GetSelectedReleasesWithOverrides()
|
||||
if err != nil {
|
||||
return false, []error{err}
|
||||
}
|
||||
if len(toSync) == 0 {
|
||||
return false, nil
|
||||
}
|
||||
} else {
|
||||
toSync = st.Releases
|
||||
toSync, err := st.GetSelectedReleasesWithOverrides()
|
||||
if err != nil {
|
||||
return false, []error{err}
|
||||
}
|
||||
if len(toSync) == 0 {
|
||||
return false, nil
|
||||
}
|
||||
|
||||
toDelete, err := st.DetectReleasesToBeDeletedForSync(helm, toSync)
|
||||
|
||||
@@ -1242,11 +1242,6 @@ func (st *HelmState) SelectReleasesWithOverrides() ([]Release, error) {
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
for _, r := range rs {
|
||||
spec := r.ReleaseSpec
|
||||
st.ApplyOverrides(&spec)
|
||||
r.ReleaseSpec = spec
|
||||
}
|
||||
return rs, nil
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user