public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(sync): make error log showing when error (#577) 

In debug mode, there was an error log display even when there was no error.
This PR fixes this issue.
This commit is contained in:
sgandon 2019-05-06 16:28:12 +02:00 committed by KUOKA Yusuke
parent 0ea5960ef2
commit d683ea1d7b
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
state/state.go
View File

@ -367,9 +367,11 @@ func (st *HelmState) SyncReleases(affectedReleases *AffectedReleases, helm helme
} else {
affectedReleases.Upgraded = append(affectedReleases.Upgraded, release)
installedVersion, err := st.getDeployedVersion(context, helm, release)
//err is not really impacting so just ignors it
st.logger.Debugf("getting deployed release version failed:%v", err)
release.installedVersion = installedVersion
if err != nil { //err is not really impacting so just log it
st.logger.Debugf("getting deployed release version failed:%v", err)
} else {
release.installedVersion = installedVersion
}
}
if relErr == nil {