From d683ea1d7b8ff65a2d6b1a4857f718c9815b3ea1 Mon Sep 17 00:00:00 2001 From: sgandon Date: Mon, 6 May 2019 16:28:12 +0200 Subject: [PATCH] fix(sync): make error log showing when error (#577) In debug mode, there was an error log display even when there was no error. This PR fixes this issue. --- state/state.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/state/state.go b/state/state.go index 84cee14c..c0e7b94c 100644 --- a/state/state.go +++ b/state/state.go @@ -367,9 +367,11 @@ func (st *HelmState) SyncReleases(affectedReleases *AffectedReleases, helm helme } else { affectedReleases.Upgraded = append(affectedReleases.Upgraded, release) installedVersion, err := st.getDeployedVersion(context, helm, release) - //err is not really impacting so just ignors it - st.logger.Debugf("getting deployed release version failed:%v", err) - release.installedVersion = installedVersion + if err != nil { //err is not really impacting so just log it + st.logger.Debugf("getting deployed release version failed:%v", err) + } else { + release.installedVersion = installedVersion + } } if relErr == nil {