public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #172 from mumoshu/diff-against-new-release 

feat: `helmfile diff` also works against non-existent releases
This commit is contained in:
KUOKA Yusuke 2018-06-25 16:15:09 +09:00 committed by GitHub
parent 6856c6e979 da337e8724
commit af1914c575
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
helmexec/exec.go
View File

@ -77,7 +77,7 @@ func (helm *execer) DecryptSecret(name string) (string, error) {
}
func (helm *execer) DiffRelease(name, chart string, flags ...string) error {
out, err := helm.exec(append([]string{"diff", "upgrade", name, chart}, flags...)...)
out, err := helm.exec(append([]string{"diff", "upgrade", "--allow-unreleased", name, chart}, flags...)...)
helm.write(out)
return err
}

4
helmexec/exec_test.go
View File

@ -139,14 +139,14 @@ func Test_DiffRelease(t *testing.T) {
var buffer bytes.Buffer
helm := MockExecer(&buffer, "dev")
helm.DiffRelease("release", "chart", "--timeout 10", "--wait")
expected := "exec: helm diff upgrade release chart --timeout 10 --wait --kube-context dev\n"
expected := "exec: helm diff upgrade --allow-unreleased release chart --timeout 10 --wait --kube-context dev\n"
if buffer.String() != expected {
t.Errorf("helmexec.DiffRelease()\nactual = %v\nexpect = %v", buffer.String(), expected)
}
buffer.Reset()
helm.DiffRelease("release", "chart")
expected = "exec: helm diff upgrade release chart --kube-context dev\n"
expected = "exec: helm diff upgrade --allow-unreleased release chart --kube-context dev\n"
if buffer.String() != expected {
t.Errorf("helmexec.DiffRelease()\nactual = %v\nexpect = %v", buffer.String(), expected)
}