public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: remove unused parameters to fix unparam lint errors 

Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/743ab4eb-0700-4e55-85df-78ed46a50f7c
This commit is contained in:
copilot-swe-agent[bot] 2026-03-24 23:03:21 +00:00 committed by yxxhero
parent ec7302c9dc
commit 4343f6447f
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/state/helmx.go
View File

@ -237,7 +237,7 @@ func (st *HelmState) appendWaitFlags(flags []string, helm helmexec.Interface, re
return flags
}
func (st *HelmState) shouldUseAtomic(release *ReleaseSpec, ops *SyncOpts) bool {
func (st *HelmState) shouldUseAtomic(release *ReleaseSpec) bool {
switch {
case release.Atomic != nil:
return *release.Atomic
@ -251,7 +251,7 @@ func (st *HelmState) appendAtomicFlags(flags []string, release *ReleaseSpec, ops
return flags
}
if st.shouldUseAtomic(release, ops) {
if st.shouldUseAtomic(release) {
flags = append(flags, "--atomic")
}

8
pkg/state/state.go
View File

@ -1141,7 +1141,7 @@ func (st *HelmState) SyncReleases(affectedReleases *AffectedReleases, helm helme
if relErr == nil && st.shouldUseKubedog(release, opts) {
if trackErr := st.trackWithKubedog(gocontext.Background(), release, helm, opts); trackErr != nil {
st.logger.Warnf("kubedog tracking failed for release %s: %v", release.Name, trackErr)
st.handleKubedogFailure(context, helm, release, trackErr, m, affectedReleases)
st.handleKubedogFailure(context, helm, release, m, affectedReleases)
}
}
} else {
@ -1164,7 +1164,7 @@ func (st *HelmState) SyncReleases(affectedReleases *AffectedReleases, helm helme
if st.shouldUseKubedog(release, opts) {
if trackErr := st.trackWithKubedog(gocontext.Background(), release, helm, opts); trackErr != nil {
st.logger.Warnf("kubedog tracking failed for release %s: %v", release.Name, trackErr)
st.handleKubedogFailure(context, helm, release, trackErr, m, affectedReleases)
st.handleKubedogFailure(context, helm, release, m, affectedReleases)
}
}
}
@ -1283,8 +1283,8 @@ func (st *HelmState) performSyncOrReinstallOfRelease(affectedReleases *AffectedR
return nil
}
func (st *HelmState) handleKubedogFailure(context helmexec.HelmContext, helm helmexec.Interface, release *ReleaseSpec, trackErr error, m *sync.Mutex, affectedReleases *AffectedReleases) {
if !st.shouldUseAtomic(release, nil) {
func (st *HelmState) handleKubedogFailure(context helmexec.HelmContext, helm helmexec.Interface, release *ReleaseSpec, m *sync.Mutex, affectedReleases *AffectedReleases) {
if !st.shouldUseAtomic(release) {
return
}