From 4343f6447f1925244153106f967d8a1b1368110c Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 24 Mar 2026 23:03:21 +0000 Subject: [PATCH] fix: remove unused parameters to fix unparam lint errors Co-authored-by: yxxhero <11087727+yxxhero@users.noreply.github.com> Agent-Logs-Url: https://github.com/helmfile/helmfile/sessions/743ab4eb-0700-4e55-85df-78ed46a50f7c --- pkg/state/helmx.go | 4 ++-- pkg/state/state.go | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/state/helmx.go b/pkg/state/helmx.go index b49eb114..2d461cd1 100644 --- a/pkg/state/helmx.go +++ b/pkg/state/helmx.go @@ -237,7 +237,7 @@ func (st *HelmState) appendWaitFlags(flags []string, helm helmexec.Interface, re return flags } -func (st *HelmState) shouldUseAtomic(release *ReleaseSpec, ops *SyncOpts) bool { +func (st *HelmState) shouldUseAtomic(release *ReleaseSpec) bool { switch { case release.Atomic != nil: return *release.Atomic @@ -251,7 +251,7 @@ func (st *HelmState) appendAtomicFlags(flags []string, release *ReleaseSpec, ops return flags } - if st.shouldUseAtomic(release, ops) { + if st.shouldUseAtomic(release) { flags = append(flags, "--atomic") } diff --git a/pkg/state/state.go b/pkg/state/state.go index 03e56ed5..bf5f2fbd 100644 --- a/pkg/state/state.go +++ b/pkg/state/state.go @@ -1141,7 +1141,7 @@ func (st *HelmState) SyncReleases(affectedReleases *AffectedReleases, helm helme if relErr == nil && st.shouldUseKubedog(release, opts) { if trackErr := st.trackWithKubedog(gocontext.Background(), release, helm, opts); trackErr != nil { st.logger.Warnf("kubedog tracking failed for release %s: %v", release.Name, trackErr) - st.handleKubedogFailure(context, helm, release, trackErr, m, affectedReleases) + st.handleKubedogFailure(context, helm, release, m, affectedReleases) } } } else { @@ -1164,7 +1164,7 @@ func (st *HelmState) SyncReleases(affectedReleases *AffectedReleases, helm helme if st.shouldUseKubedog(release, opts) { if trackErr := st.trackWithKubedog(gocontext.Background(), release, helm, opts); trackErr != nil { st.logger.Warnf("kubedog tracking failed for release %s: %v", release.Name, trackErr) - st.handleKubedogFailure(context, helm, release, trackErr, m, affectedReleases) + st.handleKubedogFailure(context, helm, release, m, affectedReleases) } } } @@ -1283,8 +1283,8 @@ func (st *HelmState) performSyncOrReinstallOfRelease(affectedReleases *AffectedR return nil } -func (st *HelmState) handleKubedogFailure(context helmexec.HelmContext, helm helmexec.Interface, release *ReleaseSpec, trackErr error, m *sync.Mutex, affectedReleases *AffectedReleases) { - if !st.shouldUseAtomic(release, nil) { +func (st *HelmState) handleKubedogFailure(context helmexec.HelmContext, helm helmexec.Interface, release *ReleaseSpec, m *sync.Mutex, affectedReleases *AffectedReleases) { + if !st.shouldUseAtomic(release) { return }