test: add nil ops test and rename misleading test names

- Add test case for appendHideNotesFlags with ops=nil to prevent
  regression
- Rename force-from-default-nil-release-* to
  force-from-default-nil-force-* for clarity (release.Force is nil,
  not the release itself)

Signed-off-by: yxxhero <aiopsclub@163.com>
This commit is contained in:
yxxhero 2026-03-11 18:19:28 +08:00
parent 03aac8ec78
commit 3dff3d610a
2 changed files with 11 additions and 2 deletions

View File

@ -442,6 +442,15 @@ func TestAppendHideNotesFlags(t *testing.T) {
expected: []string{"--hide-notes"},
},
},
{
name: "no hide-notes when ops is nil",
args: args{
flags: []string{},
helm: testutil.NewVersionHelmExec("3.16.0"),
opt: nil,
expected: []string{},
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {

View File

@ -339,7 +339,7 @@ func TestHelmState_flagsForUpgrade(t *testing.T) {
},
},
{
name: "force-from-default-nil-release-helm3",
name: "force-from-default-nil-force-helm3",
defaults: HelmSpec{
Force: true,
CreateNamespace: &disable,
@ -358,7 +358,7 @@ func TestHelmState_flagsForUpgrade(t *testing.T) {
},
},
{
name: "force-from-default-nil-release-helm4",
name: "force-from-default-nil-force-helm4",
defaults: HelmSpec{
Force: true,
CreateNamespace: &disable,