From 3dff3d610a88b4ed4139a82c64f9beab8f6762f5 Mon Sep 17 00:00:00 2001
From: yxxhero <aiopsclub@163.com>
Date: Wed, 11 Mar 2026 18:19:28 +0800
Subject: [PATCH] test: add nil ops test and rename misleading test names

- Add test case for appendHideNotesFlags with ops=nil to prevent
  regression
- Rename force-from-default-nil-release-* to
  force-from-default-nil-force-* for clarity (release.Force is nil,
  not the release itself)

Signed-off-by: yxxhero <aiopsclub@163.com>
---
 pkg/state/helmx_test.go | 9 +++++++++
 pkg/state/state_test.go | 4 ++--
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/pkg/state/helmx_test.go b/pkg/state/helmx_test.go
index 80b8d5fe..d4cab5ff 100644
--- a/pkg/state/helmx_test.go
+++ b/pkg/state/helmx_test.go
@@ -442,6 +442,15 @@ func TestAppendHideNotesFlags(t *testing.T) {
 				expected: []string{"--hide-notes"},
 			},
 		},
+		{
+			name: "no hide-notes when ops is nil",
+			args: args{
+				flags:    []string{},
+				helm:     testutil.NewVersionHelmExec("3.16.0"),
+				opt:      nil,
+				expected: []string{},
+			},
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
diff --git a/pkg/state/state_test.go b/pkg/state/state_test.go
index 730cafb9..9fc5d893 100644
--- a/pkg/state/state_test.go
+++ b/pkg/state/state_test.go
@@ -339,7 +339,7 @@ func TestHelmState_flagsForUpgrade(t *testing.T) {
 			},
 		},
 		{
-			name: "force-from-default-nil-release-helm3",
+			name: "force-from-default-nil-force-helm3",
 			defaults: HelmSpec{
 				Force:           true,
 				CreateNamespace: &disable,
@@ -358,7 +358,7 @@ func TestHelmState_flagsForUpgrade(t *testing.T) {
 			},
 		},
 		{
-			name: "force-from-default-nil-release-helm4",
+			name: "force-from-default-nil-force-helm4",
 			defaults: HelmSpec{
 				Force:           true,
 				CreateNamespace: &disable,