public_git/helmfile
1
0
Fork 0
mirror of https://github.com/helmfile/helmfile.git synced 2026-10-04 15:59:38 +02:00
Code Issues Projects Releases Wiki Activity

Fix helmfile --namespace ns delete to not fail consistently

Browse Source 
Until now `helmfile delete` with helm v3 had been failing when `--namespace` is provided. Helmfile was missing the fact that in helm v3 namespace must be passed instead of tiller-namespace to scope releases to be deleted.

```
err: release "b-1" failed: helm3rc2 exited with status 1:
  Error: uninstall: Release not loaded: b-1: release: not found
in ./helmfile.yaml: release "b-1" failed: helm3rc2 exited with status 1:
  Error: uninstall: Release not loaded: b-1: release: not found
```
This commit is contained in:
Yusuke Kuoka
2019-11-02 15:52:07 +09:00
parent f47d8ea256
commit 30751e94f7
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/state/state.go
+2
View File
@@ -1143,6 +1143,8 @@ func (st *HelmState) DeleteReleases(affectedReleases *AffectedReleases, helm hel
return nil
}
st.ApplyOverrides(&release)
flags := []string{}
if purge && !isHelm3() {
flags = append(flags, "--purge")