From 30751e94f780fb909b209ec513a952e31775e267 Mon Sep 17 00:00:00 2001 From: Yusuke Kuoka Date: Sat, 2 Nov 2019 15:21:54 +0900 Subject: [PATCH] Fix `helmfile --namespace ns delete` to not fail consistently Until now `helmfile delete` with helm v3 had been failing when `--namespace` is provided. Helmfile was missing the fact that in helm v3 namespace must be passed instead of tiller-namespace to scope releases to be deleted. ``` err: release "b-1" failed: helm3rc2 exited with status 1: Error: uninstall: Release not loaded: b-1: release: not found in ./helmfile.yaml: release "b-1" failed: helm3rc2 exited with status 1: Error: uninstall: Release not loaded: b-1: release: not found ``` --- pkg/state/state.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/state/state.go b/pkg/state/state.go index 075f9c2f..e9191545 100644 --- a/pkg/state/state.go +++ b/pkg/state/state.go @@ -1143,6 +1143,8 @@ func (st *HelmState) DeleteReleases(affectedReleases *AffectedReleases, helm hel return nil } + st.ApplyOverrides(&release) + flags := []string{} if purge && !isHelm3() { flags = append(flags, "--purge")