public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: invalid duration passed to helm 3 upgrade (#864) 

Fixes #863
This commit is contained in:
KUOKA Yusuke 2019-09-19 08:30:29 +09:00 committed by GitHub
parent b762ab0b78
commit 2e98e907b0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/state/state.go
View File

@ -1343,7 +1343,11 @@ func (st *HelmState) flagsForUpgrade(helm helmexec.Interface, release *ReleaseSp
timeout = *release.Timeout timeout = *release.Timeout
} }
if timeout != 0 { if timeout != 0 {
flags = append(flags, "--timeout", fmt.Sprintf("%d", timeout)) duration := strconv.Itoa(timeout)
if isHelm3() {
duration += "s"
}
flags = append(flags, "--timeout", duration)
} }
if release.Force != nil && *release.Force || release.Force == nil && st.HelmDefaults.Force { if release.Force != nil && *release.Force || release.Force == nil && st.HelmDefaults.Force {