public_git
/
helmfile
mirror of https://github.com/helmfile/helmfile.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

feat(diff): Pass namespace to helm-diff 

Tested manually by running `helmfile diff` with debug logging:

```yaml
helmDefaults:
  tillerNamespace: foo

charts:
  - name: grafana
    namespace: grafana
    chart: stable/grafana
```

```console
$ ./helmfile --log-level debug diff
Comparing grafana stable/grafana
exec: helm diff upgrade --allow-unreleased grafana stable/grafana --namespace grafana --tiller-namespace=foo
```

Resolves #179
This commit is contained in:
Yusuke KUOKA 2018-08-22 11:20:22 +09:00
parent 545a4a3efa
commit 127dd857df
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
state/state.go
View File

@ -271,12 +271,14 @@ func (state *HelmState) DiffReleases(helm helmexec.Interface, additionalValues [
go func() { go func() {
for release := range jobQueue { for release := range jobQueue {
errs := []error{} errs := []error{}
// Plugin command doesn't support explicit namespace
release.Namespace = "" state.applyDefaultsTo(release)
flags, err := flagsForRelease(helm, state.BaseChartPath, release) flags, err := flagsForRelease(helm, state.BaseChartPath, release)
if err != nil { if err != nil {
errs = append(errs, err) errs = append(errs, err)
} }
for _, value := range additionalValues { for _, value := range additionalValues {
valfile, err := filepath.Abs(value) valfile, err := filepath.Abs(value)
if err != nil { if err != nil {