From 127dd857df003c84e19c676da0e53f0a3b67e7ea Mon Sep 17 00:00:00 2001 From: Yusuke KUOKA Date: Wed, 22 Aug 2018 11:20:22 +0900 Subject: [PATCH] feat(diff): Pass namespace to helm-diff Tested manually by running `helmfile diff` with debug logging: ```yaml helmDefaults: tillerNamespace: foo charts: - name: grafana namespace: grafana chart: stable/grafana ``` ```console $ ./helmfile --log-level debug diff Comparing grafana stable/grafana exec: helm diff upgrade --allow-unreleased grafana stable/grafana --namespace grafana --tiller-namespace=foo ``` Resolves #179 --- state/state.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/state/state.go b/state/state.go index c23f57e1..8abcff79 100644 --- a/state/state.go +++ b/state/state.go @@ -271,12 +271,14 @@ func (state *HelmState) DiffReleases(helm helmexec.Interface, additionalValues [ go func() { for release := range jobQueue { errs := []error{} - // Plugin command doesn't support explicit namespace - release.Namespace = "" + + state.applyDefaultsTo(release) + flags, err := flagsForRelease(helm, state.BaseChartPath, release) if err != nil { errs = append(errs, err) } + for _, value := range additionalValues { valfile, err := filepath.Abs(value) if err != nil {