mirror of
https://github.com/TheGrandWazoo/freenas-proxmox.git
synced 2026-10-21 11:16:10 +02:00
fix: pin truenas-proxmox-multipath to the exact base package version (#299)
TrueNASMultipath.pm calls the base plugin's private helpers, and from 4.0.2
it also calls SUPER::volume_resize. So it only works with the truenas-proxmox
built from the same commit. `>= 3.1.0` let apt pair 4.0.2 multipath with
a 3.2.5 or 4.0.1 base, which fails at runtime. `(= ${VERSION})` makes apt
upgrade or hold the two together. A CI check fails the build if the
template ever drifts.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit ccc4ae27e1)
This commit is contained in:
@@ -271,6 +271,14 @@ jobs:
|
||||
echo "==> Package info (truenas-proxmox-multipath):"
|
||||
dpkg-deb --info "${{ steps.vars.outputs.multipath_deb_file }}"
|
||||
|
||||
# Multipath calls the base plugin's private helpers and SUPER:: methods,
|
||||
# so it must be pinned to the exact base version built alongside it (#299).
|
||||
VERSION="${{ steps.vars.outputs.version }}"
|
||||
DEPENDS="$(dpkg-deb -f "${{ steps.vars.outputs.multipath_deb_file }}" Depends)"
|
||||
echo "==> multipath Depends: ${DEPENDS}"
|
||||
echo "${DEPENDS}" | grep -qF "truenas-proxmox (= ${VERSION})" \
|
||||
|| { echo "::error::multipath must depend on truenas-proxmox (= ${VERSION})"; exit 1; }
|
||||
|
||||
- name: Upload package artifacts
|
||||
uses: actions/upload-artifact@v4
|
||||
with:
|
||||
|
||||
@@ -358,7 +358,7 @@ sudo apt update && sudo apt install truenas-proxmox-multipath
|
||||
|
||||
</details>
|
||||
|
||||
This installs `open-iscsi` and `multipath-tools` as dependencies and registers the `truenas-multipath` storage type. See [Configuration → Multipath Storage](#multipath-storage) for the extra field it needs, and [docs/architecture.md](docs/architecture.md) for how it differs from the default single-path `iscsi://` model.
|
||||
This installs `open-iscsi` and `multipath-tools` as dependencies and registers the `truenas-multipath` storage type. From v4.0.2 on, the package requires the **exact same version** of `truenas-proxmox`, so apt always upgrades (or holds) the two together ([#299](https://github.com/TheGrandWazoo/freenas-proxmox/issues/299)). See [Configuration → Multipath Storage](#multipath-storage) for the extra field it needs, and [docs/architecture.md](docs/architecture.md) for how it differs from the default single-path `iscsi://` model.
|
||||
|
||||
---
|
||||
|
||||
|
||||
@@ -2,7 +2,7 @@ Package: truenas-proxmox-multipath
|
||||
Version: ${VERSION}
|
||||
Architecture: all
|
||||
Maintainer: KSA Technologies, LLC <theprofessor@ksatechnologies.com>
|
||||
Depends: truenas-proxmox (>= 3.1.0), open-iscsi, multipath-tools
|
||||
Depends: truenas-proxmox (= ${VERSION}), open-iscsi, multipath-tools
|
||||
Section: perl
|
||||
Priority: optional
|
||||
Homepage: https://github.com/TheGrandWazoo/truenas-proxmox
|
||||
|
||||
Reference in New Issue
Block a user