removed `/app` volume from dockerfile

Specifying a volume at `/app` (in the Dockerfile) makes it difficult to
use this image as a base image for derived images. Due to this, we have
removed the `VOLUME` instruction that mounts `/app` as a volume.

The `/app` path continues to function like it did before. As a result if
you want to mount your php application into the container, mount your
application source at `/app` using `-v
/path/on/application/source:/app`.
This commit is contained in:
Sameer Naik 2015-10-06 21:53:41 +05:30
parent d9317111a4
commit 6fd7ffd22a
3 changed files with 6 additions and 8 deletions

View File

@ -15,7 +15,6 @@ COPY rootfs/ /
USER $BITNAMI_APP_USER
EXPOSE 3000
VOLUME ["/app"]
WORKDIR /app
ENTRYPOINT ["/entrypoint.sh"]

View File

@ -289,6 +289,12 @@ using the `bats` command.
bats test.sh
```
# Changelog
## 4.1.1-0-r01 (2015-10-07)
- `/app` directory is no longer exported as a volume. This caused problems when building on top of the image, since changes in the volume are not persisted between Dockerfile `RUN` instructions. To keep the previous behavior (so that you can mount the volume in another container), create the container with the `-v /app` option.
# Contributing
We'd love for you to contribute to this Docker image. You can request new features by creating an

View File

@ -57,13 +57,6 @@ teardown() {
[ "$status" = 0 ]
}
@test "all the volumes exposed" {
docker inspect $CONTAINER_NAME | {
run grep "\"Volumes\":" -A 1
[[ "$output" =~ "/app" ]]
}
}
@test "port 3000 exposed" {
add_app
docker exec -d $CONTAINER_NAME sh -c 'npm install express && node server.js'