From 6fd7ffd22ad467d72bf6ffb7740a84eb66c19f1e Mon Sep 17 00:00:00 2001 From: Sameer Naik Date: Tue, 6 Oct 2015 21:53:41 +0530 Subject: [PATCH] removed `/app` volume from dockerfile Specifying a volume at `/app` (in the Dockerfile) makes it difficult to use this image as a base image for derived images. Due to this, we have removed the `VOLUME` instruction that mounts `/app` as a volume. The `/app` path continues to function like it did before. As a result if you want to mount your php application into the container, mount your application source at `/app` using `-v /path/on/application/source:/app`. --- bitnami/node/Dockerfile | 1 - bitnami/node/README.md | 6 ++++++ bitnami/node/test.sh | 7 ------- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/bitnami/node/Dockerfile b/bitnami/node/Dockerfile index ee1c48b98085..deaa662e752c 100644 --- a/bitnami/node/Dockerfile +++ b/bitnami/node/Dockerfile @@ -15,7 +15,6 @@ COPY rootfs/ / USER $BITNAMI_APP_USER EXPOSE 3000 -VOLUME ["/app"] WORKDIR /app ENTRYPOINT ["/entrypoint.sh"] diff --git a/bitnami/node/README.md b/bitnami/node/README.md index f62f58c7b921..f5c09ec92c8c 100644 --- a/bitnami/node/README.md +++ b/bitnami/node/README.md @@ -289,6 +289,12 @@ using the `bats` command. bats test.sh ``` +# Changelog + +## 4.1.1-0-r01 (2015-10-07) + +- `/app` directory is no longer exported as a volume. This caused problems when building on top of the image, since changes in the volume are not persisted between Dockerfile `RUN` instructions. To keep the previous behavior (so that you can mount the volume in another container), create the container with the `-v /app` option. + # Contributing We'd love for you to contribute to this Docker image. You can request new features by creating an diff --git a/bitnami/node/test.sh b/bitnami/node/test.sh index a7e4cf7c7320..9c0d1ed4a2ed 100644 --- a/bitnami/node/test.sh +++ b/bitnami/node/test.sh @@ -57,13 +57,6 @@ teardown() { [ "$status" = 0 ] } -@test "all the volumes exposed" { - docker inspect $CONTAINER_NAME | { - run grep "\"Volumes\":" -A 1 - [[ "$output" =~ "/app" ]] - } -} - @test "port 3000 exposed" { add_app docker exec -d $CONTAINER_NAME sh -c 'npm install express && node server.js'