public_git/bambuddy
1
0
Fork 0
mirror of https://github.com/maziggy/bambuddy.git synced 2026-10-17 19:36:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #348 from sbcrumb/fix/duplicate-error-notifications

Browse Source 
Fix duplicate HMS error notifications from race condition
This commit is contained in:
MartinNYHC
2026-02-13 08:11:28 +01:00
committed by GitHub
parent 179a9de521 c5246e60fc
commit ac9bbc354a
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/app/main.py
+3 -2
View File
@@ -416,6 +416,9 @@ async def on_printer_status_change(printer_id: int, state: PrinterState):
# Find new errors that haven't been notified yet
new_error_codes = current_error_codes - previously_notified
# Update tracking immediately to prevent duplicate notifications from concurrent callbacks
_notified_hms_errors[printer_id] = current_error_codes
if new_error_codes:
# Get the actual new errors for the notification
# Filter to severity >= 2 (skip informational/status messages like H2D sends)
@@ -486,8 +489,6 @@ async def on_printer_status_change(printer_id: int, state: PrinterState):
except Exception as e:
logging.getLogger(__name__).warning(f"HMS error notification failed: {e}")
# Update tracking with all current errors
_notified_hms_errors[printer_id] = current_error_codes
else:
# No HMS errors - clear tracking so future errors get notified
if printer_id in _notified_hms_errors: