public_git/bambuddy
1
0
Fork 0
mirror of https://github.com/maziggy/bambuddy.git synced 2026-09-30 03:01:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(inventory): assign-spool picker note visible on mobile (#793 follow-up)

Browse Source 
The original #793 fix added the spool note as an HTML title= tooltip
on each picker button in AssignSpoolModal.tsx. title= only surfaces
on hover, which doesn't exist on touch devices — phone users tapping
a card just selected it, the note never appeared. Users who store
their tracking ID in the note field were blind on mobile (raised by
@EmcetPL on the closed issue).

Render the note as a small muted truncated line directly under the
weight on both the internal-inventory branch (line 436-ish) and the
Spoolman branch (line 510-ish): text-[10px] text-bambu-gray/70 mt-1
truncate, kept inside the truthy `&&` guard so empty notes don't add
a blank row. The existing title={spool.note} is preserved on the new
<p> so desktop hover and mobile long-press still surface the full
untruncated text for notes that overflow the truncate.

Mirrored across both inventory branches per the parity rule
(internal and Spoolman pickers stay shape-equal). No backend change,
no new state, no popover, no new touch target.
This commit is contained in:
maziggy
2026-06-27 09:56:15 +02:00
parent 93cae4dddd
commit 91e4219994
4 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+2
View File
File diff suppressed because one or more lines are too long
frontend/src/components/AssignSpoolModal.tsx
+10
View File
@@ -438,6 +438,11 @@ export function AssignSpoolModal({ isOpen, onClose, printerId, amsId, trayId, tr
{Math.max(0, Math.round(spool.label_weight - spool.weight_used))} / {spool.label_weight}g
</p>
)}
{spool.note && (
<p className="text-[10px] text-bambu-gray/70 mt-1 truncate" title={spool.note}>
{spool.note}
</p>
)}
</button>
))}
</div>
@@ -513,6 +518,11 @@ export function AssignSpoolModal({ isOpen, onClose, printerId, amsId, trayId, tr
{Math.max(0, Math.round(spool.label_weight - spool.weight_used))} / {spool.label_weight}g
</p>
)}
{spool.note && (
<p className="text-[10px] text-bambu-gray/70 mt-1 truncate" title={spool.note}>
{spool.note}
</p>
)}
</button>
))}
</div>
static/assets/index-CfzVLrcT.js → static/assets/index-CoslqvGC.js
+1 -1
View File
File diff suppressed because one or more lines are too long
static/index.html
+1 -1
View File
@@ -26,7 +26,7 @@
<!-- Splash screens for iOS -->
<link rel="apple-touch-startup-image" href="/img/android-chrome-512x512.png" />
<script type="module" crossorigin src="/assets/index-CfzVLrcT.js"></script>
<script type="module" crossorigin src="/assets/index-CoslqvGC.js"></script>
<link rel="stylesheet" crossorigin href="/assets/index-CFvgt_ZD.css">
</head>
<body>