public_git/bambuddy
1
0
Fork 0
mirror of https://github.com/maziggy/bambuddy.git synced 2026-09-30 03:01:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

Suppress Bandit false positives in virtual printer and tests

Browse Source 
B108: /tmp paths in test mocks (not real filesystem access).
B104: string comparisons against "0.0.0.0" (not socket binds).
This commit is contained in:
maziggy
2026-02-10 17:41:16 +01:00
parent d334e2a3ef
commit 51f08a5c86
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/app/services/virtual_printer/ftp_server.py
+1 -1
View File
@@ -276,7 +276,7 @@ class FTPSession:
sockname = self.writer.get_extra_info("sockname")
ip = sockname[0] if sockname else "127.0.0.1"
# 0.0.0.0 is not routable — fall back to control connection IP
if ip == "0.0.0.0":
if ip == "0.0.0.0": # nosec B104
ip = "127.0.0.1"
# Format IP and port for PASV response
backend/app/services/virtual_printer/tcp_proxy.py
+2 -2
View File
@@ -390,8 +390,8 @@ class FTPTLSProxy(TLSProxy):
# Determine our local IP from the control connection socket
sockname = client_writer.get_extra_info("sockname")
local_ip = sockname[0] if sockname else "0.0.0.0"
if local_ip in ("0.0.0.0", "::"):
local_ip = sockname[0] if sockname else "0.0.0.0" # nosec B104
if local_ip in ("0.0.0.0", "::"): # nosec B104
local_ip = "127.0.0.1"
# Connect to target printer with TLS
backend/tests/unit/services/test_virtual_printer.py
+3 -3
View File
@@ -926,7 +926,7 @@ class TestVirtualPrinterManagerServerModeIPOverride:
patch.object(
manager._cert_service,
"generate_certificates",
return_value=(Path("/tmp/cert.pem"), Path("/tmp/key.pem")),
return_value=(Path("/tmp/cert.pem"), Path("/tmp/key.pem")), # nosec B108
),
):
mock_ssdp_cls.return_value.start = AsyncMock()
@@ -955,7 +955,7 @@ class TestVirtualPrinterManagerServerModeIPOverride:
patch.object(
manager._cert_service,
"generate_certificates",
return_value=(Path("/tmp/cert.pem"), Path("/tmp/key.pem")),
return_value=(Path("/tmp/cert.pem"), Path("/tmp/key.pem")), # nosec B108
) as mock_gen_certs,
):
await manager._start_server_mode()
@@ -978,7 +978,7 @@ class TestVirtualPrinterManagerServerModeIPOverride:
patch.object(
manager._cert_service,
"generate_certificates",
return_value=(Path("/tmp/cert.pem"), Path("/tmp/key.pem")),
return_value=(Path("/tmp/cert.pem"), Path("/tmp/key.pem")), # nosec B108
) as mock_gen_certs,
):
await manager._start_server_mode()