public_git/bambuddy
1
0
Fork 0
mirror of https://github.com/maziggy/bambuddy.git synced 2026-10-09 15:35:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fixed CodeQL Alert #68: Stack trace exposure in archives.py

Browse Source
This commit is contained in:
maziggy
2026-02-01 16:20:07 +01:00
parent dce9c8bc06
commit 4dad18a331
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/app/api/routes/archives.py
+6 -3
View File
@@ -901,7 +901,8 @@ async def rescan_all_archives(db: AsyncSession = Depends(get_db)):
updated += 1
except Exception as e:
errors.append({"id": archive.id, "error": str(e)})
logger.exception(f"Failed to rescan archive {archive.id}: {e}")
errors.append({"id": archive.id, "error": "Failed to parse 3MF file"})
await db.commit()
return {"updated": updated, "errors": errors}
@@ -944,7 +945,8 @@ async def backfill_content_hashes(db: AsyncSession = Depends(get_db)):
archive.content_hash = ArchiveService.compute_file_hash(file_path)
updated += 1
except Exception as e:
errors.append({"id": archive.id, "error": str(e)})
logger.exception(f"Failed to compute hash for archive {archive.id}: {e}")
errors.append({"id": archive.id, "error": "Failed to compute hash"})
await db.commit()
return {"updated": updated, "errors": errors}
@@ -2134,7 +2136,8 @@ async def upload_archives_bulk(
else:
errors.append({"filename": file.filename, "error": "Failed to process"})
except Exception as e:
errors.append({"filename": file.filename, "error": str(e)})
logger.exception(f"Failed to upload archive {file.filename}: {e}")
errors.append({"filename": file.filename, "error": "Failed to process file"})
finally:
if temp_path.exists():
temp_path.unlink()