public_git/bambuddy
1
0
Fork 0
mirror of https://github.com/maziggy/bambuddy.git synced 2026-10-07 23:01:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix progress milestone notification showing wrong time unit

Browse Source 
The remaining_time from printer state is in minutes (from mc_remaining_time),
but _format_duration() expects seconds. This caused "17h 47m" to display as
"17m" in milestone notifications.

Closes #157
This commit is contained in:
maziggy
2026-01-27 08:53:48 +01:00
parent b9495877fc
commit 2e03fca2df
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/app/main.py
+3 -2
View File
@@ -437,10 +437,11 @@ async def on_printer_status_change(printer_id: int, state: PrinterState):
printer = result.scalar_one_or_none()
printer_name = printer.name if printer else f"Printer {printer_id}"
filename = state.subtask_name or state.gcode_file or "Unknown"
remaining_time = state.remaining_time
# remaining_time is in minutes, convert to seconds for notification
remaining_time_seconds = state.remaining_time * 60 if state.remaining_time else None
await notification_service.on_print_progress(
printer_id, printer_name, filename, current_milestone, db, remaining_time
printer_id, printer_name, filename, current_milestone, db, remaining_time_seconds
)
except Exception as e:
logging.getLogger(__name__).warning(f"Progress milestone notification failed: {e}")