public_git
/
actions-runner-controller
mirror of https://github.com/actions-runner-controller/actions-runner-controller.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix RunnerDeployment to be able to finish rollout (#1213) 

I found that #1179 was unable to finish rollout of an RunnerDeployment update(like runner env update). It was able to create a new RunnerReplicaSet with the desired spec, but unable to tear down the older ones. This fixes that.
This commit is contained in:
Yusuke Kuoka 2022-03-13 10:10:24 +09:00 committed by GitHub
parent b83db7be8f
commit adc889ce8a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
controllers/runner_pod_owner.go
View File

@ -434,7 +434,6 @@ func syncRunnerPodsOwners(ctx context.Context, c client.Client, log logr.Logger,
log.V(2).Info("BUG: Redundant object was already annotated")
}
}
return nil, err
} else if retained > newDesiredReplicas {
log.V(2).Info("Waiting sync before scale down", "retained", retained, "newDesiredReplicas", newDesiredReplicas)