From adc889ce8ac57919237da87b7bf3ea6e8d027e09 Mon Sep 17 00:00:00 2001 From: Yusuke Kuoka Date: Sun, 13 Mar 2022 10:10:24 +0900 Subject: [PATCH] Fix RunnerDeployment to be able to finish rollout (#1213) I found that #1179 was unable to finish rollout of an RunnerDeployment update(like runner env update). It was able to create a new RunnerReplicaSet with the desired spec, but unable to tear down the older ones. This fixes that. --- controllers/runner_pod_owner.go | 1 - 1 file changed, 1 deletion(-) diff --git a/controllers/runner_pod_owner.go b/controllers/runner_pod_owner.go index 7bc826c9..6cf1ca23 100644 --- a/controllers/runner_pod_owner.go +++ b/controllers/runner_pod_owner.go @@ -434,7 +434,6 @@ func syncRunnerPodsOwners(ctx context.Context, c client.Client, log logr.Logger, log.V(2).Info("BUG: Redundant object was already annotated") } } - return nil, err } else if retained > newDesiredReplicas { log.V(2).Info("Waiting sync before scale down", "retained", retained, "newDesiredReplicas", newDesiredReplicas)