From c7be8b3358c9cfcc00c35e94a899decae072f9ff Mon Sep 17 00:00:00 2001 From: Jim Wu Date: Wed, 12 Aug 2026 23:38:02 -0700 Subject: [PATCH] ggml-hip : remove -funsafe-math-optimizations (llama/26696) It enables -fassociative-math, which reassociates FP reductions and can flip greedy argmax on RDNA3.5 (e.g. MTP speculative decode diverging from the non-speculative baseline). Drop it so HIP builds are IEEE-conformant. Co-authored-by: Jim Wu --- ggml/src/ggml-hip/CMakeLists.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/ggml/src/ggml-hip/CMakeLists.txt b/ggml/src/ggml-hip/CMakeLists.txt index bbc51797c..47f16f56c 100644 --- a/ggml/src/ggml-hip/CMakeLists.txt +++ b/ggml/src/ggml-hip/CMakeLists.txt @@ -126,9 +126,6 @@ if (GGML_HIP_EXPORT_METRICS) set(CMAKE_HIP_FLAGS "${CMAKE_HIP_FLAGS} -Rpass-analysis=kernel-resource-usage --save-temps") endif() -# Fast math for HIP, like CUDA's -use_fast_math. Not -ffast-math: that implies -ffinite-math-only, which breaks ggml's INFINITY masking and produces NaNs. -set(CMAKE_HIP_FLAGS "${CMAKE_HIP_FLAGS} -funsafe-math-optimizations") - if (NOT GGML_CUDA_FA) add_compile_definitions(GGML_CUDA_NO_FA) endif()