public_git
/
whisper.cpp
mirror of https://github.com/ggml-org/whisper.cpp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

vad : free vad_segments in whisper_vad (#3463) 

This commit fixes multiple issues:

* memory leak because vad_segments is never released
* avoid segmentation fault when whisper_vad_segments_from_samples returns nullptr.
* avoid potential segmentation fault when the app fails to allocate memory for filtered samples and the vad context is released but also get released withing state itself when whisper_free_state is called
This commit is contained in:
Silviu Caragea 2025-10-10 04:20:21 +00:00 committed by GitHub
parent 98930fded1
commit 85d1d3d3dc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/whisper.cpp
View File

@ -6620,6 +6620,9 @@ static bool whisper_vad(
whisper_vad_segments * vad_segments = whisper_vad_segments_from_samples(vctx, vad_params, samples, n_samples); whisper_vad_segments * vad_segments = whisper_vad_segments_from_samples(vctx, vad_params, samples, n_samples);
if(!vad_segments)
return false;
if (vad_segments->data.size() > 0) { if (vad_segments->data.size() > 0) {
state->has_vad_segments = true; state->has_vad_segments = true;
ctx->state->vad_segments.clear(); ctx->state->vad_segments.clear();
@ -6662,7 +6665,6 @@ static bool whisper_vad(
} catch (const std::bad_alloc & /* e */) { } catch (const std::bad_alloc & /* e */) {
WHISPER_LOG_ERROR("%s: failed to allocate memory for filtered samples\n", __func__); WHISPER_LOG_ERROR("%s: failed to allocate memory for filtered samples\n", __func__);
whisper_vad_free_segments(vad_segments); whisper_vad_free_segments(vad_segments);
whisper_vad_free(vctx);
return false; return false;
} }
@ -6768,6 +6770,7 @@ static bool whisper_vad(
__func__, n_samples, filtered_n_samples, 100.0f * (1.0f - (float)filtered_n_samples / n_samples)); __func__, n_samples, filtered_n_samples, 100.0f * (1.0f - (float)filtered_n_samples / n_samples));
} }
whisper_vad_free_segments(vad_segments);
return true; return true;
} }