public_git
/
whisper.cpp
mirror of https://github.com/ggml-org/whisper.cpp.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

server: return proper HTTP status codes for error responses (#3707) 

Several error paths in the /inference and /load endpoints returned
HTTP 200 with a JSON error body, making it impossible for clients
to distinguish errors from successful responses by status code.

Set 400 for client errors (missing file field, unreadable audio,
missing/invalid model) and 500 for server errors (ffmpeg conversion
failure). The two existing status-code sites (499 for client
disconnect, 500 for processing failure) are unchanged.
This commit is contained in:
Igor Loskutov 2026-03-16 07:33:06 -04:00 committed by GitHub
parent 27fa20774a
commit 136dc2eb12
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
examples/server/server.cpp
View File

@ -811,6 +811,7 @@ int main(int argc, char ** argv) {
{ {
fprintf(stderr, "error: no 'file' field in the request\n"); fprintf(stderr, "error: no 'file' field in the request\n");
const std::string error_resp = "{\"error\":\"no 'file' field in the request\"}"; const std::string error_resp = "{\"error\":\"no 'file' field in the request\"}";
res.status = 400;
res.set_content(error_resp, "application/json"); res.set_content(error_resp, "application/json");
return; return;
} }
@ -837,6 +838,7 @@ int main(int argc, char ** argv) {
std::string error_resp = "{\"error\":\"Failed to execute ffmpeg command.\"}"; std::string error_resp = "{\"error\":\"Failed to execute ffmpeg command.\"}";
const bool is_converted = convert_to_wav(temp_filename, error_resp); const bool is_converted = convert_to_wav(temp_filename, error_resp);
if (!is_converted) { if (!is_converted) {
res.status = 500;
res.set_content(error_resp, "application/json"); res.set_content(error_resp, "application/json");
return; return;
} }
@ -846,6 +848,7 @@ int main(int argc, char ** argv) {
{ {
fprintf(stderr, "error: failed to read WAV file '%s'\n", temp_filename.c_str()); fprintf(stderr, "error: failed to read WAV file '%s'\n", temp_filename.c_str());
const std::string error_resp = "{\"error\":\"failed to read WAV file\"}"; const std::string error_resp = "{\"error\":\"failed to read WAV file\"}";
res.status = 400;
res.set_content(error_resp, "application/json"); res.set_content(error_resp, "application/json");
std::remove(temp_filename.c_str()); std::remove(temp_filename.c_str());
return; return;
@ -857,6 +860,7 @@ int main(int argc, char ** argv) {
{ {
fprintf(stderr, "error: failed to read audio data\n"); fprintf(stderr, "error: failed to read audio data\n");
const std::string error_resp = "{\"error\":\"failed to read audio data\"}"; const std::string error_resp = "{\"error\":\"failed to read audio data\"}";
res.status = 400;
res.set_content(error_resp, "application/json"); res.set_content(error_resp, "application/json");
return; return;
} }
@ -1127,6 +1131,7 @@ int main(int argc, char ** argv) {
{ {
fprintf(stderr, "error: no 'model' field in the request\n"); fprintf(stderr, "error: no 'model' field in the request\n");
const std::string error_resp = "{\"error\":\"no 'model' field in the request\"}"; const std::string error_resp = "{\"error\":\"no 'model' field in the request\"}";
res.status = 400;
res.set_content(error_resp, "application/json"); res.set_content(error_resp, "application/json");
return; return;
} }
@ -1135,6 +1140,7 @@ int main(int argc, char ** argv) {
{ {
fprintf(stderr, "error: 'model': %s not found!\n", model.c_str()); fprintf(stderr, "error: 'model': %s not found!\n", model.c_str());
const std::string error_resp = "{\"error\":\"model not found!\"}"; const std::string error_resp = "{\"error\":\"model not found!\"}";
res.status = 400;
res.set_content(error_resp, "application/json"); res.set_content(error_resp, "application/json");
return; return;
} }