public_git
/
unpoller_unpoller
mirror of https://github.com/unpoller/unpoller.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

protect against nil return values

This commit is contained in:
David Newhall II 2019-10-01 19:53:43 -07:00
parent 0d1a1cb308
commit e171786e83
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
integrations/inputunifi/unifipoller/unifi.go
View File

@ -62,9 +62,8 @@ func (u *UnifiPoller) PollController() error {
// Only run this if the authentication procedure didn't return error. // Only run this if the authentication procedure didn't return error.
_ = u.CollectAndReport() _ = u.CollectAndReport()
} }
if u.Config.MaxErrors >= 0 && u.errorCount > u.Config.MaxErrors { if u.errorCount > 0 {
return fmt.Errorf("reached maximum error count, stopping poller (%d > %d)", return fmt.Errorf("controller or influxdb errors, stopping poller")
u.errorCount, u.Config.MaxErrors)
} }
} }
return nil return nil
@ -116,6 +115,9 @@ func (u *UnifiPoller) CollectMetrics() (*Metrics, error) {
// This is where we can manipuate the returned data or make arbitrary decisions. // This is where we can manipuate the returned data or make arbitrary decisions.
// This function currently adds parent device names to client metrics. // This function currently adds parent device names to client metrics.
func (u *UnifiPoller) AugmentMetrics(metrics *Metrics) error { func (u *UnifiPoller) AugmentMetrics(metrics *Metrics) error {
if metrics == nil || metrics.Devices == nil || metrics.Clients == nil {
return fmt.Errorf("nil metrics, augment impossible")
}
devices := make(map[string]string) devices := make(map[string]string)
bssdIDs := make(map[string]string) bssdIDs := make(map[string]string)
for _, r := range metrics.UAPs { for _, r := range metrics.UAPs {