auto fix lint rules

pkg/datadogunifi/datadog.go

@@ -140,7 +140,7 @@ func (u *DatadogUnifi) setConfigDefaults() {
 		u.options = append(u.options, statsd.WithNamespace(*u.Namespace))
 	}
 
-	if u.Tags != nil && len(u.Tags) > 0 {
+	if len(u.Tags) > 0 {
 		u.options = append(u.options, statsd.WithTags(u.Tags))
 	}
 
@@ -378,7 +378,7 @@ func (u *DatadogUnifi) switchExport(r report, v any) { //nolint:cyclop
 	case *unifi.Event:
 		u.batchEvent(r, v)
 	case *unifi.IDS:
-		u.batchIDS(r, v)
+		u.batchIDs(r, v)
 	case *unifi.Alarm:
 		u.batchAlarms(r, v)
 	case *unifi.Anomaly:

pkg/datadogunifi/events.go

@@ -11,11 +11,11 @@ import (
 // These constants are used as names for printed/logged counters.
 const (
 	eventT = item("Event")
-	idsT   = item("IDS")
+	idsT   = item("IDs")
 )
 
-// batchIDS generates intrusion detection datapoints for Datadog.
+// batchIDs generates intrusion detection datapoints for Datadog.
-func (u *DatadogUnifi) batchIDS(r report, i *unifi.IDS) { // nolint:dupl
+func (u *DatadogUnifi) batchIDs(r report, i *unifi.IDS) { // nolint:dupl
 	if time.Since(i.Datetime) > u.Interval.Duration+time.Second {
 		return // The event is older than our interval, ignore it.
 	}

pkg/influxunifi/events.go

@@ -9,11 +9,11 @@ import (
 // These constants are used as names for printed/logged counters.
 const (
 	eventT = item("Event")
-	idsT   = item("IDS")
+	idsT   = item("IDs")
 )
 
-// batchIDS generates intrusion detection datapoints for InfluxDB.
+// batchIDs generates intrusion detection datapoints for InfluxDB.
-func (u *InfluxUnifi) batchIDS(r report, i *unifi.IDS) { // nolint:dupl
+func (u *InfluxUnifi) batchIDs(r report, i *unifi.IDS) { // nolint:dupl
 	if time.Since(i.Datetime) > u.Interval.Duration+time.Second {
 		return // The event is older than our interval, ignore it.
 	}

pkg/influxunifi/influxdb.go

@@ -452,7 +452,7 @@ func (u *InfluxUnifi) switchExport(r report, v any) { //nolint:cyclop
 	case *unifi.Event:
 		u.batchEvent(r, v)
 	case *unifi.IDS:
-		u.batchIDS(r, v)
+		u.batchIDs(r, v)
 	case *unifi.Alarm:
 		u.batchAlarms(r, v)
 	case *unifi.Anomaly:

pkg/inputunifi/collectevents.go

@@ -34,7 +34,7 @@ func (u *InputUnifi) collectControllerEvents(c *Controller) ([]any, error) {
 
 	type caller func([]any, []*unifi.Site, *Controller) ([]any, error)
 
-	for _, call := range []caller{u.collectIDS, u.collectAnomalies, u.collectAlarms, u.collectEvents} {
+	for _, call := range []caller{u.collectIDs, u.collectAnomalies, u.collectAlarms, u.collectEvents} {
 		if newLogs, err = call(logs, sites, c); err != nil {
 			return logs, err
 		}
@@ -123,9 +123,9 @@ func (u *InputUnifi) collectEvents(logs []any, sites []*unifi.Site, c *Controlle
 	return logs, nil
 }
 
-func (u *InputUnifi) collectIDS(logs []any, sites []*unifi.Site, c *Controller) ([]any, error) {
+func (u *InputUnifi) collectIDs(logs []any, sites []*unifi.Site, c *Controller) ([]any, error) {
-	if *c.SaveIDS {
+	if *c.SaveIDs {
-		u.LogDebugf("Collecting controller IDS data: %s (%s)", c.URL, c.ID)
+		u.LogDebugf("Collecting controller IDs data: %s (%s)", c.URL, c.ID)
 
 		for _, s := range sites {
 			events, err := c.Unifi.GetIDSSite(s)

pkg/inputunifi/input.go

@@ -38,7 +38,7 @@ type Controller struct {
 	SaveAnomal *bool        `json:"save_anomalies" toml:"save_anomalies" xml:"save_anomalies" yaml:"save_anomalies"`
 	SaveAlarms *bool        `json:"save_alarms"    toml:"save_alarms"    xml:"save_alarms"    yaml:"save_alarms"`
 	SaveEvents *bool        `json:"save_events"    toml:"save_events"    xml:"save_events"    yaml:"save_events"`
-	SaveIDS    *bool        `json:"save_ids"       toml:"save_ids"       xml:"save_ids"       yaml:"save_ids"`
+	SaveIDs    *bool        `json:"save_ids"       toml:"save_ids"       xml:"save_ids"       yaml:"save_ids"`
 	SaveDPI    *bool        `json:"save_dpi"       toml:"save_dpi"       xml:"save_dpi"       yaml:"save_dpi"`
 	SaveRogue  *bool        `json:"save_rogue"     toml:"save_rogue"     xml:"save_rogue"     yaml:"save_rogue"`
 	HashPII    *bool        `json:"hash_pii"       toml:"hash_pii"       xml:"hash_pii"       yaml:"hash_pii"`
@@ -231,8 +231,8 @@ func (u *InputUnifi) setDefaults(c *Controller) { //nolint:cyclop
 		c.SaveRogue = &f
 	}
 
-	if c.SaveIDS == nil {
+	if c.SaveIDs == nil {
-		c.SaveIDS = &f
+		c.SaveIDs = &f
 	}
 
 	if c.SaveEvents == nil {
@@ -296,8 +296,8 @@ func (u *InputUnifi) setControllerDefaults(c *Controller) *Controller { //nolint
 		c.SaveDPI = u.Default.SaveDPI
 	}
 
-	if c.SaveIDS == nil {
+	if c.SaveIDs == nil {
-		c.SaveIDS = u.Default.SaveIDS
+		c.SaveIDs = u.Default.SaveIDs
 	}
 
 	if c.SaveRogue == nil {

pkg/inputunifi/interface.go

@@ -127,12 +127,12 @@ func (u *InputUnifi) logController(c *Controller) {
 	u.Logf("   => Username: %s (has password: %v)", c.User, c.Pass != "")
 	u.Logf("   => Hash PII %v / Drop PII %v / Poll Sites: %s", *c.HashPII, *c.DropPII, strings.Join(c.Sites, ", "))
 	u.Logf("   => Save Sites %v / Save DPI %v (metrics)", *c.SaveSites, *c.SaveDPI)
-	u.Logf("   => Save Events %v / Save IDS %v (logs)", *c.SaveEvents, *c.SaveIDS)
+	u.Logf("   => Save Events %v / Save IDs %v (logs)", *c.SaveEvents, *c.SaveIDs)
 	u.Logf("   => Save Alarms %v / Anomalies %v (logs)", *c.SaveAlarms, *c.SaveAnomal)
 	u.Logf("   => Save Rogue APs: %v", *c.SaveRogue)
 }
 
-// Events allows you to pull only events (and IDS) from the UniFi Controller.
+// Events allows you to pull only events (and IDs) from the UniFi Controller.
 // This does not fully respect HashPII, but it may in the future!
 // Use Filter.Path to pick a specific controller, otherwise poll them all!
 func (u *InputUnifi) Events(filter *poller.Filter) (*poller.Events, error) {

pkg/inputunifi/updateweb.go

@@ -44,7 +44,7 @@ func formatControllers(controllers []*Controller) []*Controller {
 			SaveAlarms: c.SaveAlarms,
 			SaveRogue:  c.SaveRogue,
 			SaveEvents: c.SaveEvents,
-			SaveIDS:    c.SaveIDS,
+			SaveIDs:    c.SaveIDs,
 			SaveDPI:    c.SaveDPI,
 			HashPII:    c.HashPII,
 			DropPII:    c.DropPII,

pkg/lokiunifi/report.go

@@ -48,7 +48,7 @@ func (r *Report) ProcessEventLogs(events *poller.Events) *Logs {
 	for _, e := range events.Logs {
 		switch event := e.(type) {
 		case *unifi.IDS:
-			r.IDS(event, logs)
+			r.IDs(event, logs)
 		case *unifi.Event:
 			r.Event(event, logs)
 		case *unifi.Alarm:
@@ -65,7 +65,7 @@ func (r *Report) ProcessEventLogs(events *poller.Events) *Logs {
 
 func (r *Report) String() string {
 	return fmt.Sprintf("%s: %d, %s: %d, %s: %d, %s: %d, Dur: %v",
-		typeEvent, r.Counts[typeEvent], typeIDS, r.Counts[typeIDS],
+		typeEvent, r.Counts[typeEvent], typeIDs, r.Counts[typeIDs],
 		typeAlarm, r.Counts[typeAlarm], typeAnomaly, r.Counts[typeAnomaly],
 		time.Since(r.Start).Round(time.Millisecond))
 }

pkg/lokiunifi/report_ids.go

@@ -6,15 +6,15 @@ import (
 	"github.com/unpoller/unifi"
 )
 
-const typeIDS = "IDS"
+const typeIDs = "IDs"
 
 // event stores a structured event Event for batch sending to Loki.
-func (r *Report) IDS(event *unifi.IDS, logs *Logs) {
+func (r *Report) IDs(event *unifi.IDS, logs *Logs) {
 	if event.Datetime.Before(r.Oldest) {
 		return
 	}
 
-	r.Counts[typeIDS]++ // increase counter and append new log line.
+	r.Counts[typeIDs]++ // increase counter and append new log line.
 
 	logs.Streams = append(logs.Streams, LogStream{
 		Entries: [][]string{{strconv.FormatInt(event.Datetime.UnixNano(), 10), event.Msg}},

pkg/unittest/dep.go

@@ -24,7 +24,7 @@ func NewTestSetup(t *testing.T) *TestRig {
 		SaveAnomal: &enabled,
 		SaveAlarms: &enabled,
 		SaveEvents: &enabled,
-		SaveIDS:    &enabled,
+		SaveIDs:    &enabled,
 		SaveDPI:    &enabled,
 		SaveRogue:  &enabled,
 		SaveSites:  &enabled,