public_git
/
unpoller_unpoller
mirror of https://github.com/unpoller/unpoller.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

move collector initialization up in Run method 

all logging methods rely on the collector being initialized. When this isn't the case logging anything causes the whole app to crash with a nil pointer dereference. Specifically the datadog plugin causes unpoller to crash when it's disabled because it write a debug log on an uninitialized collector.
This commit is contained in:
Daniel Schauenberg 2022-11-09 11:43:16 +01:00 committed by GitHub
parent 8902b7ad9d
commit 5b04503cf9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
integrations/datadogunifi/datadog.go
View File

@ -190,6 +190,7 @@ func (u *DatadogUnifi) setConfigDefaults() {
// Run runs a ticker to poll the unifi server and update Datadog.
func (u *DatadogUnifi) Run(c poller.Collect) error {
u.Collector = c
if u.Disable {
u.LogDebugf("Datadog config is disabled, output is disabled.")
return nil
@ -198,7 +199,6 @@ func (u *DatadogUnifi) Run(c poller.Collect) error {
u.LogErrorf("DataDog config is missing and is not disabled: Datadog output is disabled!")
return nil
}
u.Collector = c
u.Logf("Datadog is configured.")
u.setConfigDefaults()